Bug 99619 - security/fragroute package not including dependencies
Summary: security/fragroute package not including dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-29 21:50 UTC by Richard Bejtlich
Modified: 2006-07-04 16:46 UTC (History)
0 users

See Also:


Attachments
fragroute.patch (1.33 KB, patch)
2006-07-02 09:22 UTC, Stefan Walter
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Bejtlich 2006-06-29 21:50:22 UTC
I just installed fragroute from the 6-STABLE package.  It did not
automatically add the dependent packages libdnet or libevent.

Fix: 

# pkg_add -vr libdnet
looking up ftp.freebsd.org
connecting to ftp.freebsd.org:21
setting passive mode
opening data connection
initiating transfer
Fetching ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-6-stable/Latest/libdnet.tbz...x +CONTENTS
x +COMMENT
x +DESC
x +MTREE_DIRS
x man/man3/dnet.3.gz
x man/man8/dnet.8.gz
x bin/dnet-config
x sbin/dnet
x lib/libdnet.a
x lib/libdnet.la
x lib/libdnet.so
x lib/libdnet.so.1
x include/dnet/addr.h
x include/dnet/arp.h
x include/dnet/blob.h
x include/dnet/eth.h
x include/dnet/fw.h
x include/dnet/icmp.h
x include/dnet/intf.h
x include/dnet/ip.h
x include/dnet/ip6.h
x include/dnet/os.h
x include/dnet/rand.h
x include/dnet/route.h
x include/dnet/tcp.h
x include/dnet/tun.h
x include/dnet/udp.h
x include/dnet.h
tar command returns 0 status
 Done.
extract: Package name is libdnet-1.10_1
extract: CWD to /usr/local
extract: /usr/local/man/man3/dnet.3.gz
extract: /usr/local/man/man8/dnet.8.gz
extract: /usr/local/bin/dnet-config
extract: /usr/local/sbin/dnet
extract: /usr/local/lib/libdnet.a
extract: /usr/local/lib/libdnet.la
extract: /usr/local/lib/libdnet.so
extract: /usr/local/lib/libdnet.so.1
extract: /usr/local/include/dnet/addr.h
extract: /usr/local/include/dnet/arp.h
extract: /usr/local/include/dnet/blob.h
extract: /usr/local/include/dnet/eth.h
extract: /usr/local/include/dnet/fw.h
extract: /usr/local/include/dnet/icmp.h
extract: /usr/local/include/dnet/intf.h
extract: /usr/local/include/dnet/ip.h
extract: /usr/local/include/dnet/ip6.h
extract: /usr/local/include/dnet/os.h
extract: /usr/local/include/dnet/rand.h
extract: /usr/local/include/dnet/route.h
extract: /usr/local/include/dnet/tcp.h
extract: /usr/local/include/dnet/tun.h
extract: /usr/local/include/dnet/udp.h
extract: /usr/local/include/dnet.h
extract: execute '/sbin/ldconfig -m /usr/local/lib'
extract: CWD to .
Running mtree for libdnet-1.10_1..
mtree -U -f +MTREE_DIRS -d -e -p /usr/local >/dev/null
Attempting to record package into /var/db/pkg/libdnet-1.10_1..
Package libdnet-1.10_1 registered in /var/db/pkg/libdnet-1.10_1

# pkg_add -vr libevent
looking up ftp.freebsd.org
connecting to ftp.freebsd.org:21
setting passive mode
opening data connection
initiating transfer
Fetching ftp://ftp.freebsd.org/pub/FreeBSD/ports/i386/packages-6-stable/Latest/libevent.tbz...x +CONTENTS
x +COMMENT
x +DESC
x +MTREE_DIRS
x man/man3/event.3.gz
x man/man3/event_init.3.gz
x man/man3/event_dispatch.3.gz
x man/man3/event_loop.3.gz
x man/man3/event_loopexit.3.gz
x man/man3/event_set.3.gz
x man/man3/event_add.3.gz
x man/man3/event_del.3.gz
x man/man3/event_once.3.gz
x man/man3/event_pending.3.gz
x man/man3/event_initialized.3.gz
x man/man3/event_priority_init.3.gz
x man/man3/event_priority_set.3.gz
x man/man3/evtimer_set.3.gz
x man/man3/evtimer_add.3.gz
x man/man3/evtimer_del.3.gz
x man/man3/evtimer_pending.3.gz
x man/man3/evtimer_initialized.3.gz
x man/man3/signal_set.3.gz
x man/man3/signal_add.3.gz
x man/man3/signal_del.3.gz
x man/man3/signal_pending.3.gz
x man/man3/signal_initialized.3.gz
x man/man3/bufferevent_new.3.gz
x man/man3/bufferevent_free.3.gz
x man/man3/bufferevent_write.3.gz
x man/man3/bufferevent_write_buffer.3.gz
x man/man3/bufferevent_read.3.gz
x man/man3/bufferevent_enable.3.gz
x man/man3/bufferevent_disable.3.gz
x man/man3/bufferevent_settimeout.3.gz
x man/man3/evbuffer_new.3.gz
x man/man3/evbuffer_free.3.gz
x man/man3/evbuffer_add.3.gz
x man/man3/evbuffer_add_buffer.3.gz
x man/man3/evbuffer_add_printf.3.gz
x man/man3/evbuffer_drain.3.gz
x man/man3/evbuffer_write.3.gz
x man/man3/evbuffer_read.3.gz
x man/man3/evbuffer_find.3.gz
x include/event.h
x lib/libevent-1.1a.so
x lib/libevent-1.1a.so.1
x lib/libevent.a
x lib/libevent.la
x lib/libevent.so
tar command returns 0 status
 Done.
extract: Package name is libevent-1.1a_1
extract: CWD to /usr/local
extract: /usr/local/man/man3/event.3.gz
extract: /usr/local/man/man3/event_init.3.gz
extract: /usr/local/man/man3/event_dispatch.3.gz
extract: /usr/local/man/man3/event_loop.3.gz
extract: /usr/local/man/man3/event_loopexit.3.gz
extract: /usr/local/man/man3/event_set.3.gz
extract: /usr/local/man/man3/event_add.3.gz
extract: /usr/local/man/man3/event_del.3.gz
extract: /usr/local/man/man3/event_once.3.gz
extract: /usr/local/man/man3/event_pending.3.gz
extract: /usr/local/man/man3/event_initialized.3.gz
extract: /usr/local/man/man3/event_priority_init.3.gz
extract: /usr/local/man/man3/event_priority_set.3.gz
extract: /usr/local/man/man3/evtimer_set.3.gz
extract: /usr/local/man/man3/evtimer_add.3.gz
extract: /usr/local/man/man3/evtimer_del.3.gz
extract: /usr/local/man/man3/evtimer_pending.3.gz
extract: /usr/local/man/man3/evtimer_initialized.3.gz
extract: /usr/local/man/man3/signal_set.3.gz
extract: /usr/local/man/man3/signal_add.3.gz
extract: /usr/local/man/man3/signal_del.3.gz
extract: /usr/local/man/man3/signal_pending.3.gz
extract: /usr/local/man/man3/signal_initialized.3.gz
extract: /usr/local/man/man3/bufferevent_new.3.gz
extract: /usr/local/man/man3/bufferevent_free.3.gz
extract: /usr/local/man/man3/bufferevent_write.3.gz
extract: /usr/local/man/man3/bufferevent_write_buffer.3.gz
extract: /usr/local/man/man3/bufferevent_read.3.gz
extract: /usr/local/man/man3/bufferevent_enable.3.gz
extract: /usr/local/man/man3/bufferevent_disable.3.gz
extract: /usr/local/man/man3/bufferevent_settimeout.3.gz
extract: /usr/local/man/man3/evbuffer_new.3.gz
extract: /usr/local/man/man3/evbuffer_free.3.gz
extract: /usr/local/man/man3/evbuffer_add.3.gz
extract: /usr/local/man/man3/evbuffer_add_buffer.3.gz
extract: /usr/local/man/man3/evbuffer_add_printf.3.gz
extract: /usr/local/man/man3/evbuffer_drain.3.gz
extract: /usr/local/man/man3/evbuffer_write.3.gz
extract: /usr/local/man/man3/evbuffer_read.3.gz
extract: /usr/local/man/man3/evbuffer_find.3.gz
extract: /usr/local/include/event.h
extract: /usr/local/lib/libevent-1.1a.so
extract: /usr/local/lib/libevent-1.1a.so.1
extract: /usr/local/lib/libevent.a
extract: /usr/local/lib/libevent.la
extract: /usr/local/lib/libevent.so
extract: execute '/sbin/ldconfig -m /usr/local/lib'
extract: CWD to .
Running mtree for libevent-1.1a_1..
mtree -U -f +MTREE_DIRS -d -e -p /usr/local >/dev/null
Attempting to record package into /var/db/pkg/libevent-1.1a_1..
Package libevent-1.1a_1 registered in /var/db/pkg/libevent-1.1a_1
poweredge:/root# rehash
poweredge:/root# fragtest
Usage: fragtest TESTS ... <host>

  where TESTS is any combination of the following (or "all"):

  ping          prerequisite for all tests
  ip-opt        determine supported IP options
  ip-tracert    determine path to target
  frag          try 8-byte IP fragments
  frag-new      try 8-byte fwd-overlapping IP fragments, favoring new data
  frag-old      try 8-byte fwd-overlapping IP fragments, favoring old data
  frag-timeout  determine IP fragment reassembly timeout
How-To-Repeat: pkg_add -vr fragroute

# fragtest
/libexec/ld-elf.so.1: Shared object "libdnet.so.1" not found, required by "fragtest"

(after adding libdnet)

# fragtest
/libexec/ld-elf.so.1: Shared object "libevent-1.1a.so.1" not found, required by "fragtest"
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2006-06-30 01:12:55 UTC
Responsible Changed
From-To: freebsd-bugs->freebsd-ports-bugs

Make this a ports PR.
Comment 2 Stefan Walter freebsd_committer freebsd_triage 2006-07-02 09:04:48 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2006-07-02 09:22:49 UTC
Dear maintainer of security/fragroute,

a problem report has been opened concerning this port. Please see
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/99619 for details.

I have attached a patch that does the following:
- Replace the BUILD_DEPENDS by LIB_DEPENDS on libdnet and libevent.
- Point configure at ${LOCALBASE} instead of ${PREFIX} when looking for
  the libraries.
- Use ${DATADIR} instead of ${PREFIX}/share/${PORTNAME}.

Please let me know if you approve these changes to be committed.

Regards,
Stefan
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2006-07-02 09:23:33 UTC
State Changed
From-To: open->feedback

Awaiting maintainer's feedback regarding proposed patch.
Comment 5 onatan 2006-07-02 09:39:23 UTC
On 7/2/06, Stefan Walter <stefan@freebsd.org> wrote:
> Dear maintainer of security/fragroute,
>
> a problem report has been opened concerning this port. Please see
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/99619 for details.
>
> I have attached a patch that does the following:
> - Replace the BUILD_DEPENDS by LIB_DEPENDS on libdnet and libevent.
> - Point configure at ${LOCALBASE} instead of ${PREFIX} when looking for
>   the libraries.
> - Use ${DATADIR} instead of ${PREFIX}/share/${PORTNAME}.
>
> Please let me know if you approve these changes to be committed.

I think
+		event-1.2.1:${PORTSDIR}/devel/libevent
is too granular and will break as libevent advances.
Otherwise this patch is great, thank you, Stefan.
Thank you too, Richard.
Comment 6 Stefan Walter freebsd_committer freebsd_triage 2006-07-02 18:29:27 UTC
Jonatan B, 02.07.06, 10:39h CEST:

> I think
> +		event-1.2.1:${PORTSDIR}/devel/libevent
> is too granular and will break as libevent advances.

OK, I agree it is very narrow. Let me know which granularity you'd prefer,
i.e.  either 1.2 or just 1, and I'll commit it.

Regards,
Stefan
Comment 7 onatan 2006-07-02 18:40:38 UTC
On 7/2/06, Stefan Walter <stefan@freebsd.org> wrote:
> Jonatan B, 02.07.06, 10:39h CEST:
>
> > I think
> > +             event-1.2.1:${PORTSDIR}/devel/libevent
> > is too granular and will break as libevent advances.
>
> OK, I agree it is very narrow. Let me know which granularity you'd prefer,
> i.e.  either 1.2 or just 1, and I'll commit it.

1, please. Thanks.
Comment 8 Stefan Walter freebsd_committer freebsd_triage 2006-07-04 16:45:27 UTC
State Changed
From-To: feedback->closed

Port fixed, thanks for your PR!