Bug 100780 - net-mgmt/netmond: restore correct regexp matching
Summary: net-mgmt/netmond: restore correct regexp matching
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-24 17:50 UTC by Valentin Nechayev
Modified: 2006-08-17 16:53 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Nechayev 2006-07-24 17:50:20 UTC 
patch-AA from port patches contains uncompleted 8bitization patch which
changes size of bit table for character class in real but doesn't change
its declaration. As result, regexp matching works unstable.

Fix: Apply the following patch to the port:



or separate change of CCLSKIP to another patch.

Credits to: Vsevolod Volkov--NuUWAdL3yxXznTqJM9SdqSZt8bvq5rWhCLu5ICFXDNvmA4kx
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

diff -rNu 0/usr/ports/net-mgmt/netmond/files/patch-AA 1/usr/ports/net-mgmt/netmond/files/patch-AA
--- 0/usr/ports/net-mgmt/netmond/files/patch-AA	Wed Aug 18 20:08:08 2004
+++ 1/usr/ports/net-mgmt/netmond/files/patch-AA	Mon Jul 24 19:34:44 2006
@@ -1130,4 +1130,13 @@
 +#define inascii(x)	(0255&(x))
  #define iswordc(x) 	chrtyp[inascii(x)]
  #define isinset(x, y) 	((x)[((y)&BLKIND)>>3] & (1<<((y)&BITIND)))
+
+@@ -596,7 +596,7 @@
  
+ #define ANYSKIP	2 	/* CLO ANY END ...	   */
+ #define CHRSKIP	3	/* CLO CHR chr END ...	   */
+-#define CCLSKIP 18	/* CLO CCL 16bytes END ... */
++#define CCLSKIP BITBLK+2	/* CLO CCL 32bytes END ... */
+ 
+ static char *
+ pmatch(prog, lp, ap)
How-To-Repeat: 
E.g. for string "23.203", "^[0-9]" matches; "[0-9]*" doesn't;
"^([0-9][0-9.]*)" matches again. There are another examples of unstable work
but code is more eloquent.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-07-24 17:50:56 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Фомичев Виктор 2006-08-01 09:36:59 UTC 
Approved.
Please, merge this patch with port.

Fomichev V.A.
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2006-08-15 17:13:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2006-08-17 16:53:10 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!