Bug 101252 - [patch] Add WITH_CHARSET knob to japanese/mecab-ipadic
Summary: [patch] Add WITH_CHARSET knob to japanese/mecab-ipadic
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-02 11:40 UTC by fmysh
Modified: 2006-09-09 12:50 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (484 bytes, patch)
2006-08-02 11:40 UTC, fmysh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description fmysh 2006-08-02 11:40:15 UTC 
	Add WITH_CHARSET knob to convert a dictionary.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-02 11:40:22 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 TAKATSU Tomonari 2006-08-06 09:48:32 UTC 
I modified TAOKA-san's patch and show following:

--- japanese/mecab-ipadic.orig/Makefile Tue Jul 18 21:40:09 2006
+++ japanese/mecab-ipadic/Makefile      Sun Aug  6 17:32:20 2006
@@ -24,4 +24,14 @@
 USE_PERL5_BUILD=       yes
 GNU_CONFIGURE= yes

+# Set charset (euc-jp/sjis_jis/utf8)
+.if defined(WITH_CHARSET)
+CONFIGURE_ARGS=        --with-charset=${WITH_CHARSET}
+.endif
+
+pre-everything::
+       @${ECHO_MSG} ""
+       @${ECHO_MSG} "  WITH_CHARSET=charset  set default charset (euc-jp/sjis_jis/utf8)"
+       @${ECHO_MSG} ""
+
 .include <bsd.port.mk>

Thanks.

On Wed, 2 Aug 2006 10:40:19 UT
Edwin Groothuis <edwin@FreeBSD.org> wrote:

> Maintainer of japanese/mecab-ipadic,
> 
> Please note that PR ports/101252 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/101252
> 
> -- 
> Edwin Groothuis
> edwin@FreeBSD.org
Comment 3 fmysh 2006-08-06 21:37:31 UTC 
Sorry, I got an encoding name wrong.
iconv -l says not utf8 but utf-8.
Please change the patch with s/utf8/utf-8/g.

Thank you


On 2006/08/06, at 17:48, TAKATSU Tomonari wrote:

> I modified TAOKA-san's patch and show following:
>
> --- japanese/mecab-ipadic.orig/Makefile Tue Jul 18 21:40:09 2006
> +++ japanese/mecab-ipadic/Makefile      Sun Aug  6 17:32:20 2006
> @@ -24,4 +24,14 @@
>  USE_PERL5_BUILD=       yes
>  GNU_CONFIGURE= yes
>
> +# Set charset (euc-jp/sjis_jis/utf8)
> +.if defined(WITH_CHARSET)
> +CONFIGURE_ARGS=        --with-charset=${WITH_CHARSET}
> +.endif
> +
> +pre-everything::
> +       @${ECHO_MSG} ""
> +       @${ECHO_MSG} "  WITH_CHARSET=charset  set default charset  
> (euc-jp/sjis_jis/utf8)"
> +       @${ECHO_MSG} ""
> +
>  .include <bsd.port.mk>
>
> Thanks.
>
> On Wed, 2 Aug 2006 10:40:19 UT
> Edwin Groothuis <edwin@FreeBSD.org> wrote:
>
>> Maintainer of japanese/mecab-ipadic,
>>
>> Please note that PR ports/101252 has just been submitted.
>>
>> If it contains a patch for an upgrade, an enhancement or a bug fix
>> you agree on, reply to this email stating that you approve the patch
>> and a committer will take care of it.
>>
>> The full text of the PR can be found at:
>>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/101252
>>
>> -- 
>> Edwin Groothuis
>> edwin@FreeBSD.org
>
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2006-08-06 22:41:26 UTC 
State Changed
From-To: feedback->open

maintainer approved
Comment 5 TAKATSU Tomonari 2006-08-10 12:03:53 UTC 
Finaly, the patch is following

--- japanese/mecab-ipadic.orig/Makefile Tue Jul 18 21:40:09 2006
+++ japanese/mecab-ipadic/Makefile      Sun Aug  6 17:32:20 2006
@@ -24,4 +24,14 @@
 USE_PERL5_BUILD=	yes
 GNU_CONFIGURE=	yes

+# Set charset (euc-jp/sjis_jis/utf-8)
+.if defined(WITH_CHARSET)
+CONFIGURE_ARGS=	--with-charset=${WITH_CHARSET}
+.endif
+
+pre-everything::
+	@${ECHO_MSG} ""
+	@${ECHO_MSG} "  WITH_CHARSET=charset  set default charset (euc-jp/sjis_jis/utf-8)"
+	@${ECHO_MSG} ""
+
 .include <bsd.port.mk>

Thanks.

On Sun, 6 Aug 2006 21:41:34 GMT
Edwin Groothuis <edwin@FreeBSD.org> wrote:

> Synopsis: [patch] Add WITH_CHARSET knob to japanese/mecab-ipadic
> 
> State-Changed-From-To: feedback->open
> State-Changed-By: edwin
> State-Changed-When: Sun Aug 6 21:41:26 UTC 2006
> State-Changed-Why: 
> maintainer approved
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=101252
Comment 6 fmysh 2006-08-23 16:24:05 UTC 
Edwin, can you commit the patch?

Thank you

On 2006/08/10, at 20:03, TAKATSU Tomonari wrote:

> Finaly, the patch is following
>
> --- japanese/mecab-ipadic.orig/Makefile Tue Jul 18 21:40:09 2006
> +++ japanese/mecab-ipadic/Makefile      Sun Aug  6 17:32:20 2006
> @@ -24,4 +24,14 @@
>  USE_PERL5_BUILD=	yes
>  GNU_CONFIGURE=	yes
>
> +# Set charset (euc-jp/sjis_jis/utf-8)
> +.if defined(WITH_CHARSET)
> +CONFIGURE_ARGS=	--with-charset=${WITH_CHARSET}
> +.endif
> +
> +pre-everything::
> +	@${ECHO_MSG} ""
> +	@${ECHO_MSG} "  WITH_CHARSET=charset  set default charset (euc-jp/ 
> sjis_jis/utf-8)"
> +	@${ECHO_MSG} ""
> +
>  .include <bsd.port.mk>
>
> Thanks.
>
Comment 7 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-09-09 12:50:48 UTC 
State Changed
From-To: open->closed

Committed. Thanks!