Bug 101361 - graphicsmagick failed to build
Summary: graphicsmagick failed to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-04 15:50 UTC by Bram Kuijper
Modified: 2006-08-28 17:45 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bram Kuijper 2006-08-04 15:50:13 UTC 
?> portupgrade GraphicsMagick
<snip>
</snip>
if /bin/sh ../libtool --silent --mode=compile cc -DHAVE_CONFIG_H  -I. -I. -I../magick -I../magick  -I.. -I.. -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11R6/include -I/usr/local/include/libxml2   -O -pipe -march=pentium4 -Wall -MT png.lo -MD -MP -MF ".deps/png.Tpo" -c -o png.lo png.c;  then mv -f ".deps/png.Tpo" ".deps/png.Plo"; else rm -f ".deps/png.Tpo"; exit 1; fi
png.c: In function `ReadOnePNGImage':
png.c:1712: warning: implicit declaration of function `png_access_version'
png.c:1721: error: `png_ptr' undeclared (first use in this function)
png.c:1721: error: (Each undeclared identifier is reported only once
png.c:1721: error: for each function it appears in.)
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick/work/GraphicsMagick-1.1.6/coders.
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick/work/GraphicsMagick-1.1.6.
*** Error code 1

Stop in /usr/ports/graphics/GraphicsMagick.
** Command failed [exit code 1]: /usr/bin/script -qa /tmp/portupgrade71901.0 env PORT_UPGRADE=yes make PORT_UPGRADE=yes
** Fix the problem and try again.
** Listing the failed packages (*:skipped / !:failed)
        ! graphics/GraphicsMagick (GraphicsMagick-1.1.6_1)      (compiler error)
Comment 1 Aron Stansvik 2006-08-17 10:43:12 UTC 
The following patch fixes this issue, and may be added to the port.
This has been fixed in ImageMagick, but not yet in GraphicsMagick.
I'll bug them about it.

Best regards,
Aron Stansvik

--- coders/png.c.orig   Thu Aug 17 11:37:53 2006
+++ coders/png.c        Thu Aug 17 11:38:50 2006
@@ -1709,7 +1709,7 @@
 #if defined(PNG_USE_PNGGCCRD) && defined(PNG_ASSEMBLER_CODE_SUPPORTED) \
 && (PNG_LIBPNG_VER >= 10200)
   /* Disable thread-unsafe features of pnggccrd */
-  if (png_access_version() >= 10200)
+  if (png_access_version_number() >= 10200)
   {
     png_uint_32 mmx_disable_mask=0;
     png_uint_32 asm_flags;
@@ -1718,8 +1718,8 @@
                         | PNG_ASM_FLAG_MMX_READ_FILTER_SUB   \
                         | PNG_ASM_FLAG_MMX_READ_FILTER_AVG   \
                         | PNG_ASM_FLAG_MMX_READ_FILTER_PAETH );
-    asm_flags=png_get_asm_flags(png_ptr);
-    png_set_asm_flags(png_ptr, asm_flags & ~mmx_disable_mask);
+    asm_flags=png_get_asm_flags(ping);
+    png_set_asm_flags(ping, asm_flags & ~mmx_disable_mask);
   }
 #endif
Comment 2 Aron Stansvik 2006-08-17 11:10:59 UTC 
Okay. Sent patch to GraphicsMagick developers. [1]

Aron

[1] https://sourceforge.net/tracker/index.php?func=detail&aid=1541845&group_id=73485&atid=537937
Comment 3 Remko Lodder freebsd_committer freebsd_triage 2006-08-19 14:20:06 UTC 
Responsible Changed
From-To: freebsd-i386->freebsd-ports-bugs

This is a Ports issue, not a source issue.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-08-28 17:45:18 UTC 
State Changed
From-To: open->closed

Already fixed by clsung 7 days ago - in a different manner. 
Thank you anyway.