Without x11-toolkit/tk84, the first line of /usr/local/bin/xspin is set to "#!/usr/local/bin/wish8.0 -f" because of WISH=wish8.0 in Makefile. As RUN_DEPENDS requires wish8.4, WISH must be wish8.4. How-To-Repeat: install spin without x11-toolkit/tk84
State Changed From-To: open->feedback Awaiting maintainers feedback
On 01-Sep-2006 Edwin Groothuis wrote: > Maintainer of devel/spin, > > Please note that PR ports/102738 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/102738 > > -- > Edwin Groothuis > edwin@FreeBSD.org Looks good. I am not sure of the best way to handle this. xspin does not need wish8.4 in particular, and since since wish is not needed to build I would not want to put it in BUILD_DEPENDS. Can a match be done in RUN_DEPENDS and the result picked up for the post-patch? Hmmm. Jonathan Hanna <jhanna@shaw.ca>
pav 2006-10-07 11:24:47 UTC FreeBSD ports repository Modified files: devel/spin Makefile Log: - Fix xspin runtime: sed the correct wish executable into the script PR: ports/102738 (adapted) Submitted by: <mitsuru@riken.jp> Approved by: Jonathan Hanna <jhanna@shaw.ca> (maintainer) Revision Changes Path 1.47 +3 -4 ports/devel/spin/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed a variation on your patch - I just hardcoded the wish8.4 into the script, removing the attempt of autodetection which is bound to fail in post-patch target anyway.