Bug 103082 - [patch][/usr/ports/mail/elm+ME] hdrdecode and add chinese Big5
Summary: [patch][/usr/ports/mail/elm+ME] hdrdecode and add chinese Big5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-09 22:50 UTC by pasear ©¬¿üº¸
Modified: 2006-09-21 15:00 UTC (History)
0 users

See Also:


Attachments
patch_hdrdecode.c (2.02 KB, text/plain)
2006-09-09 22:50 UTC, pasear ©¬¿üº¸
no flags Details
file.diff (847 bytes, patch)
2006-09-09 22:50 UTC, pasear ©¬¿üº¸
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pasear ©¬¿üº¸ 2006-09-09 22:50:21 UTC
    Two patches.

    patch_precompiled_sets.c for adding simple support of chinese Big5.
	Under LC_ALL=en_US.ISO8859-1,
	Chinese Big5 can be displayed well if elm treat it as ISO8859-1, that is, no treatment.
	This patch fails to work if the user specifies LC_ALL=zh_TW.Big5, 
	but elm cannot display very well in zh_TW.Big5.

	patch_hdrdecode.c:
	Many MUAs send encoded From:, To:, and Subject: with double quotes, 
	but elm just pass them undecoded.

	For example,
	From: pasear  "=?big5?B?qay//Lq4?="  <wchunhao@csie.nctu.edu.tw>
	To: pasear =?Big5?B?qay//Lq4?= <wchunhao@csie.nctu.edu.tw>
	Subject: abc""=?Big5?B?UmU6IKuixW9+?="def

	The To: works well, 
	but it cannot decode From:, where it is very common to quote encoded text.
	The Subject: line should also be decoded with prefix and postfix string intact, 
	though this usage is not common.

	Most users just thought elm cannot handle Chinese big5 when they see the undecoded
	text.

How-To-Repeat: 
    Copy the following mail to /var/mail/$USER, and run elm.


    From wchunhao@ccbsd12.csie.nctu.edu.tw Sat Sep  9 23:55:57 2006
    Received: from ccbsd12.csie.nctu.edu.tw (wchunhao@ccbsd12.csie.nctu.edu.tw [140.113.209.72])
	    by mailgate.csie.nctu.edu.tw (8.13.4/8.13.4) with ESMTP id k89FtuXe013926
		    for <wchunhao@csie.nctu.edu.tw>; Sat, 9 Sep 2006 23:55:56 +0800 (CST)
			    (envelope-from wchunhao@ccbsd12.csie.nctu.edu.tw)
	Received: (from wchunhao@localhost)
	    by ccbsd12.csie.nctu.edu.tw (8.13.6/8.13.6/Submit) id k89Ftvtd090499
		    for wchunhao@csie.nctu.edu.tw; Sat, 9 Sep 2006 23:55:57 +0800 (CST)
			    (envelope-from wchunhao)
	Date: Sat, 9 Sep 2006 23:55:57 +0800
	From: pasear  "=?big5?B?qay//Lq4?="  <wchunhao@csie.nctu.edu.tw>
	To: pasear ""=?Big5?B?qay//Lq4?="" <wchunhao@csie.nctu.edu.tw>
	Subject: abc""=?Big5?B?UmU6IKuixW9+?="def
	Message-ID: <20060909155557.GA90491@csie.nctu.edu.tw>
	MIME-Version: 1.0
	Content-Type: text/plain; charset=Big5
	Content-Disposition: inline
	Content-Transfer-Encoding: 8bit
	User-Agent: Mutt/1.5.12-2006-07-14
	Status: RO

	¤j®a¦n¡A§Ú¬O¥¿Å餤¤å
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-09 22:50:36 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Johan van Selst freebsd_committer freebsd_triage 2006-09-21 10:30:59 UTC
Responsible Changed
From-To: freebsd-ports-bugs->johans

Take this.
Comment 3 dfilter service freebsd_committer freebsd_triage 2006-09-21 14:53:02 UTC
johans      2006-09-21 13:52:51 UTC

  FreeBSD ports repository

  Added files:
    mail/elm+ME/files    patch-hdrdecode.c 
                         patch-precompiled_sets.c 
  Log:
  - Fix foreign charset decoding in headers
  - Fix handing of Big5 characters
  
  PR:             ports/103082
  Submitted by:   wchunhao@csie.nctu.edu.tw
  
  Revision  Changes    Path
  1.1       +84 -0     ports/mail/elm+ME/files/patch-hdrdecode.c (new)
  1.1       +12 -0     ports/mail/elm+ME/files/patch-precompiled_sets.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Johan van Selst freebsd_committer freebsd_triage 2006-09-21 14:54:38 UTC
State Changed
From-To: feedback->closed

Commited, after the upgrade to 2.4.123c. Thanks. 
Everything seems to work fine, but neither myself nor my terminal client 
understand Big5, so I'll believe you when you say this makes it look good...