Bug 103276 - net/samba3: Add a notice when FAM_SUPPORT is being forced.
Summary: net/samba3: Add a notice when FAM_SUPPORT is being forced.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Shaun Amott
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-14 19:00 UTC by Scot Hetzel
Modified: 2006-09-19 02:41 UTC (History)
0 users

See Also:

Attachments
file.diff (720 bytes, patch)
2006-09-14 19:00 UTC, Scot Hetzel 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scot Hetzel 2006-09-14 19:00:38 UTC 
When you have either fam/gamin installed, and then build the net/samba3 but don't select FAM_SUPPORT from the OPTIONS menu, the port builds with FAM_SUPPORT anyways.

The reason for this is that the Samba3 configure script automatically detectes the fam/gamin library and enables support for FAM.  The configure script doesn't have an option to disable this behavior.

Fix: Add a notice in pre-everything advising that FAM_SUPPORT has been forced.
How-To-Repeat: On a system without fam/gamin installed run:

make -V LIB_DEPENDS

then install either fam/gamin and run:

make -V LIB_DEPENDS

You'll see that FAM has been added to the list of LIB_DEPENDS.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-14 19:00:50 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Shaun Amott freebsd_committer freebsd_triage 2006-09-18 00:50:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->shaun

Grab.
Comment 3 Timur I. Bakeyev 2006-09-18 00:54:20 UTC 
Hi Scot!

Thanks for your report. This patch looks ok with me.

To commiter: Please, commit this patch together with the other updates
to net/samba3 port.

With best regards,
Timur.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-09-19 02:39:29 UTC 
shaun       2006-09-19 01:39:21 UTC

  FreeBSD ports repository

  Modified files:
    net/samba3           Makefile 
    net/samba3/files     samba.in 
  Added files:
    net/samba3/files     patch-include_includes.h 
  Log:
  - Maintainer reports: [1]
  
    After recent release of Samba 3.0.23c and corresponding version of
    port several problems with it were reported back by the users.
  
    - Fix for the broken OPTIONS menu due overlong line. That addresses PR
      ports/103158 and ports/102980
    - Fix build on FreeBSD 7. PR ports/102919.
    - Several fixes to the rc.d/samba script, as well as a new code.
      Should handle 'restart' properly now.
    - Remove enforcement of a daemon shutdown during deinstallation due
      several requests.
    - SAMBA_PRIVATEDIR can now be redefined.
  
  - Warn the user if FAM_SUPPORT is enabled contrary to the selected
    OPTIONS. [2]
  
  PR:             ports/103170 [1] ports/103276 [2]
  Submitted by:   Timur I. Bakeyev <timur@gnu.org> (mainainer) [1],
                  Scot Hetzel <swhetzel@gmail.com> [2]
  Approved by:    maintainer [2]
  
  Revision  Changes    Path
  1.153     +8 -14     ports/net/samba3/Makefile
  1.3       +16 -0     ports/net/samba3/files/patch-include_includes.h (new)
  1.3       +115 -79   ports/net/samba3/files/samba.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Shaun Amott freebsd_committer freebsd_triage 2006-09-19 02:41:24 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!