Bug 103763 - [PATCH] databases/mysqltcl to 3.02, rewrite and update
Summary: [PATCH] databases/mysqltcl to 3.02, rewrite and update
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-28 15:50 UTC by Martin Matuska
Modified: 2006-10-09 15:20 UTC (History)
0 users

See Also:


Attachments
file.shar (2.83 KB, text/plain)
2006-09-28 15:50 UTC, Martin Matuska
no flags Details
patch-generic-mysqltcl.c (8.53 KB, text/plain)
2006-10-07 16:40 UTC, Björn König
no flags Details
databases-mysqltcl.shar (14.07 KB, text/plain)
2006-10-09 14:32 UTC, Björn König
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matuska 2006-09-28 15:50:27 UTC
This is a rewrite of the databases/mysqltcl port to use GNU configure
No patches, clean, easy and NOT BROKEN
As program authors say, does NOT support MySQL below 4.1

I am asking hereby to take over maintainership of this port
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-09-28 15:51:14 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Björn König 2006-09-29 12:02:29 UTC
Hello,

the current version of mysqltcl is not broken although the BROKEN
statement in the Makefile claims it. The problem is a faulty header of the
latest MySQL client. I contacted already the MySQL maintainer.

I planned to submit an update to 3.02 after 6.2-RELEASE. I will take the
work of the author if this PR into account.

I don't want to give up the possibility to use mysqltcl with older
versions of MySQL.

Regards
Björn
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-07 14:02:12 UTC
Bjorn, why not going with this patch today? Or if you can get me your
version of update in next two days, it will get in before 6.2-RELEASE.
Otherwise you will have to wait for months, while the ports tree is
frozen. That would be shame.

I have unmarked the existing port BROKEN.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

A cow is a sphere that emits milk into all directions.
At least to a first approximation.
  -- An unknown physicist
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-07 14:02:50 UTC
Responsible Changed
From-To: freebsd-ports-bugs->pav

Get involved
Comment 5 Björn König 2006-10-07 16:40:50 UTC
Pav Lucistnik schrieb:
> Bjorn, why not going with this patch today? Or if you can get me your
> version of update in next two days, it will get in before 6.2-RELEASE.
> Otherwise you will have to wait for months, while the ports tree is
> frozen. That would be shame.
> 
> I have unmarked the existing port BROKEN.

The current port won't build with the latest MySQL 5.0 client port, so 
you have to replace the patch in the 'files' directory with the attached 
file; otherwise pointyhat will fail again.

I try to create an update within the next two days. At the first glance 
I can't see any problems with the submitted patch, so if I don't offer 
another update then commit the update to 3.02 of Martin Matuska please. 
In this case I will submit my changes after the port freeze.

Regards
Björn
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-07 16:53:03 UTC
> > Bjorn, why not going with this patch today? Or if you can get me your
> > version of update in next two days, it will get in before 6.2-RELEASE.
> > Otherwise you will have to wait for months, while the ports tree is
> > frozen. That would be shame.
> > 
> > I have unmarked the existing port BROKEN.
> 
> The current port won't build with the latest MySQL 5.0 client port, so 
> you have to replace the patch in the 'files' directory with the attached 
> file; otherwise pointyhat will fail again.

I actually tried to build it with latest 5.0 client port (5.0.24a), and
it built just fine:
http://hood.oook.cz/tb/logs/6-amd64/mysqltcl-3.01.log

> I try to create an update within the next two days. At the first glance 
> I can't see any problems with the submitted patch, so if I don't offer 
> another update then commit the update to 3.02 of Martin Matuska please. 
> In this case I will submit my changes after the port freeze.

Understood.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

The Phase Spider. A spider that never seems quite there.
Comment 7 Björn König 2006-10-07 17:15:24 UTC
Pav Lucistnik schrieb:

> I actually tried to build it with latest 5.0 client port (5.0.24a), and
> it built just fine:
> http://hood.oook.cz/tb/logs/6-amd64/mysqltcl-3.01.log

Right now I see that ale@ committed changes to the 
databases/mysql50-client port ten days ago that eliminate the problem. 
For this reason my patch of the last mail isn't necessary anymore.

Regards
Björn
Comment 8 Björn König 2006-10-09 14:31:30 UTC
Hello again,

I added my unofficial patch for use with MySQL 3.23 and 4.0 to the 
rewritten port.

Martin, many thanks for rewriting the port. I like to confer with you if 
you want to take the maintainership. I integrated my patch because 
during my maintainership several users asked for support with ancient 
MySQL servers and I need this feature too. That's the reason why I don't 
want to miss that patch in future updates.

Björn
Comment 9 Björn König 2006-10-09 14:32:21 UTC
Err, I forgot to attache the file.
Comment 10 Pav Lucistnik freebsd_committer freebsd_triage 2006-10-09 15:18:40 UTC
State Changed
From-To: feedback->closed

Bjorn's take on the shar was committed. 

Martin, if you want to take over maintainership, let me know.
Comment 11 dfilter service freebsd_committer freebsd_triage 2006-10-09 15:18:56 UTC
pav         2006-10-09 14:18:23 UTC

  FreeBSD ports repository

  Modified files:
    databases/mysqltcl   Makefile distinfo pkg-message-legacy 
                         pkg-plist 
    databases/mysqltcl/files patch-generic-mysqltcl.c 
  Removed files:
    databases/mysqltcl/files Makefile.bsd 
  Log:
  - Update to 3.0.2
  
  PR:             ports/103763
  Submitted by:   Martin Matuska <martin@matuska.org>
  Approved by:    Bjorn Konig <bkoenig@cs.tu-berlin.de> (maintainer)
  
  Revision  Changes    Path
  1.18      +19 -25    ports/databases/mysqltcl/Makefile
  1.8       +3 -3      ports/databases/mysqltcl/distinfo
  1.5       +0 -16     ports/databases/mysqltcl/files/Makefile.bsd (dead)
  1.2       +144 -120  ports/databases/mysqltcl/files/patch-generic-mysqltcl.c
  1.2       +0 -1      ports/databases/mysqltcl/pkg-message-legacy
  1.2       +3 -3      ports/databases/mysqltcl/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"