Bug 103941 - /usr/local/etc/rc.d/arpwatch.sh start only for one interface (patch attached)
Summary: /usr/local/etc/rc.d/arpwatch.sh start only for one interface (patch attached)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cheng-Lung Sung
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-03 15:20 UTC by Fabian Wenk
Modified: 2006-10-04 02:00 UTC (History)
0 users

See Also:

Attachments
file.diff (466 bytes, patch)
2006-10-03 15:20 UTC, Fabian Wenk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Wenk 2006-10-03 15:20:25 UTC 
Did a portupgrade from arpwatch-2.1.a15 to arpwatch-2.1.a15_2 and afterwards with the a manual restart of arpwatch I got this:

root@superman:~# /usr/local/etc/rc.d/arpwatch.sh restart
Stopping arpwatch.
Waiting for PIDS: 587 590 593.
Starting arpwatch.
arpwatch already running? (pid=44695).
root@superman:~#

root@superman:~# ps auxwww|grep arpwatch
root  44695  3.7  1.0  3172  2476  p1  S     3:49PM   0:00.20 /usr/local/sbin/arpwatch -i dc0 -f arp.dc0.dat
root@superman:~#

I have the following in my /etc/rc.conf:
arpwatch_enable="YES"
arpwatch_dir="/usr/local/arpwatch/"
arpwatch_interfaces="dc0 de0 rl0"

Fix: Did a diff to the old arpwatch.sh and created the following patch, now it is working again:
How-To-Repeat: Restart arpwatch with '/usr/local/etc/rc.d/arpwatch.sh restart' or '/usr/local/etc/rc.d/arpwatch.sh stop' and '/usr/local/etc/rc.d/arpwatch.sh start'
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-10-03 23:58:05 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Thomas Abthorpe 2006-10-04 01:17:14 UTC 
I concur with this patch, please commit.

Thomas
Comment 3 Cheng-Lung Sung freebsd_committer freebsd_triage 2006-10-04 01:50:26 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->clsung

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-10-04 01:59:02 UTC 
clsung      2006-10-04 00:58:55 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt/arpwatch    Makefile 
    net-mgmt/arpwatch/files arpwatch.sh.in 
  Log:
  - make arpwatch work fine with multiple interfaces.
  - bump PORTREVISION
  
  PR:             103941
  Submitted by:   Fabian Wenk <fabian_AT_wenks dot ch>
  Approved by:    maintainer (Thomas Abthorpe)
  
  Revision  Changes    Path
  1.47      +1 -1      ports/net-mgmt/arpwatch/Makefile
  1.7       +2 -1      ports/net-mgmt/arpwatch/files/arpwatch.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Cheng-Lung Sung freebsd_committer freebsd_triage 2006-10-04 01:59:06 UTC 
State Changed
From-To: feedback->closed

Committed. Thank You.