Bug 105191 - lang/tcl84: Tests from clock.test failing
Summary: lang/tcl84: Tests from clock.test failing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-06 00:30 UTC by Grégory Nou
Modified: 2006-12-01 15:50 UTC (History)
0 users

See Also:

Attachments
file.diff (508 bytes, patch)
2006-11-06 00:30 UTC, Grégory Nou 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grégory Nou 2006-11-06 00:30:29 UTC 
Package does not deal with locale correctly, e.g.

==== clock-3.1 clock format tests FAILED
==== Contents of test case:

    set clockval 657687766
    clock format $clockval -format {%a %b %d %I:%M:%S %p %Y}

---- Result was:
Dim nov 04 03:02:46  1990
---- Result should have been (exact matching):
Sun Nov 04 03:02:46 AM 1990
==== clock-3.1 FAILED

Fix: Patch attached with submission follows:
How-To-Repeat: set LC_ALL to any non-english language
Comment 1 Shaun Amott freebsd_committer freebsd_triage 2006-11-06 01:31:50 UTC 
State Changed
From-To: open->feedback

To which port does this PR apply?
Comment 2 Shaun Amott freebsd_committer freebsd_triage 2006-11-06 15:38:37 UTC 
State Changed
From-To: feedback->open

Feedback received.
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-01 15:34:28 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2006-12-01 15:40:34 UTC 
pav         2006-12-01 15:40:16 UTC

  FreeBSD ports repository

  Modified files:
    lang/tcl84           Makefile 
  Log:
  - Be more thorough in resetting locales to ensure successfull test run
  
  PR:             ports/105191
  Submitted by:   Gregory Nou <gregory.nou@gmail.com>
  
  Revision  Changes    Path
  1.97      +1 -1      ports/lang/tcl84/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"