Bug 105310 - [patch] net/asterisk: fix plist to let the dependent packages build
Summary: [patch] net/asterisk: fix plist to let the dependent packages build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-08 23:50 UTC by Boris Samorodov
Modified: 2007-01-03 16:22 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer freebsd_triage 2006-11-08 23:50:23 UTC
	The port net/asterisk by itself builds just fine but it's pkg-plist
	file needs to be updated to allow the dependent packages be build without
	errors. For example, net/asterisk-addons (built with tinderbox):
====================<phase 7: make package>====================
===>  Building package for asterisk-addons-1.2.3_1
Creating package /tmp/packages/All/asterisk-addons-1.2.3_1.tbz
Registering depends: asterisk-1.2.13 curl-7.15.5_1 newt-0.51.0_3 spandsp-0.0.2.p26 popt-1.7_1 speex-1.0.5_1,1 libslang-1.4.9 mpg123-0.59r_17 mysql-client-5.0.27 gettext-0.14.5_2 unixODBC-2.2.12 tiff-3.8.2 libogg-1.1.3,3 jpeg-6b_4 libiconv-1.9.2_2.
Creating bzip'd tar ball in '/tmp/packages/All/asterisk-addons-1.2.3_1.tbz'
Deleting asterisk-addons-1.2.3_1

=== Checking filesystem state
Deleting mysql-client-5.0.27
Deleting gmake-3.81_1
Deleting asterisk-1.2.13
pkg_delete: file '/usr/local/share/asterisk/sounds/priv-callerintros' doesn't exist
pkg_delete: unable to completely remove directory '/usr/local/share/asterisk/sounds/priv-callerintros'
pkg_delete: unable to completely remove directory '/usr/local/etc/asterisk'
pkg_delete: file '/var/spool/asterisk/dictate' doesn't exist
pkg_delete: unable to completely remove directory '/var/spool/asterisk/dictate'
pkg_delete: file '/var/spool/asterisk/meetme' doesn't exist
pkg_delete: unable to completely remove directory '/var/spool/asterisk/meetme'
pkg_delete: file '/var/spool/asterisk/monitor' doesn't exist
pkg_delete: unable to completely remove directory '/var/spool/asterisk/monitor'
pkg_delete: file '/var/spool/asterisk/system' doesn't exist
pkg_delete: unable to completely remove directory '/var/spool/asterisk/system'
pkg_delete: file '/var/spool/asterisk/tmp' doesn't exist
pkg_delete: unable to completely remove directory '/var/spool/asterisk/tmp'
pkg_delete: file '/var/log/asterisk/cdr-custom' doesn't exist
pkg_delete: unable to completely remove directory '/var/log/asterisk/cdr-custom'
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)
Deleting curl-7.15.5_1
Deleting mpg123-0.59r_17
Deleting newt-0.51.0_3
Deleting spandsp-0.0.2.p26
Deleting speex-1.0.5_1,1
Deleting unixODBC-2.2.12
Deleting tiff-3.8.2
Deleting popt-1.7_1
Deleting libslang-1.4.9
Deleting libogg-1.1.3,3
Deleting gettext-0.14.5_2
Deleting jpeg-6b_4
Deleting libiconv-1.9.2_2

=== Checking filesystem state after all packages deleted
================================================================
list of extra files and directories in / (not present on clean system but present after everything was deinstalled)
7732465        8 drwxr-xr-x    2 root             wheel                2560 Nov  8 22:26 usr/local/etc/asterisk
7732623        4 -r--r--r--    1 root             wheel                 190 Nov  8 22:26 usr/local/etc/asterisk/dmsmgr.conf
================================================================
build of /usr/ports/net/asterisk-addons ended at Wed Nov  8 22:26:55 UTC 2006

Fix: 1. Fix a typo: dmsmgr.conf -> dnsmgr.conf.
	2. Create all needed directories (add @exec mkdir -p <dirs>) to
	   pkg-plist file.

	After those changes net/asterisk remains happy and net/asterisk-addons
	is becomes happy too.



WBR
-- 
bsam--Eid0sV62gVEKJaFZZS52hCEiUdOrKCB0sPmRODcmxQ8mid5G
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/asterisk/Makefile,v
retrieving revision 1.61
diff -u -r1.61 Makefile
--- Makefile	20 Oct 2006 15:03:02 -0000	1.61
+++ Makefile	8 Nov 2006 22:52:36 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	asterisk
 PORTVERSION=	1.2.13
+PORTREVISION=	1
 CATEGORIES=	net
 MASTER_SITES=	http://ftp.digium.com/pub/asterisk/ \
 		http://ftp.digium.com/pub/asterisk/old-releases/
Index: pkg-plist
===================================================================
RCS file: /home/pcvs/ports/net/asterisk/pkg-plist,v
retrieving revision 1.22
diff -u -r1.22 pkg-plist
--- pkg-plist	4 Oct 2006 04:41:26 -0000	1.22
+++ pkg-plist	8 Nov 2006 22:52:37 -0000
@@ -45,7 +45,7 @@
 @exec [ -f %B/codecs.conf ] || cp %B/%f %B/codecs.conf
 @unexec if cmp -s %D/etc/asterisk/dnsmgr.conf %D/etc/asterisk/dnsmgr.conf-dist; then rm -f %D/etc/asterisk/dnsmgr.conf; fi
 etc/asterisk/dnsmgr.conf-dist
-@exec [ -f %B/dnsmgr.conf ] || cp %B/%f %B/dmsmgr.conf
+@exec [ -f %B/dnsmgr.conf ] || cp %B/%f %B/dnsmgr.conf
 @unexec if cmp -s %D/etc/asterisk/dundi.conf %D/etc/asterisk/dundi.conf-dist; then rm -f %D/etc/asterisk/dundi.conf; fi
 etc/asterisk/dundi.conf-dist
 @exec [ -f %B/dundi.conf ] || cp %B/%f %B/dundi.conf
@@ -734,6 +734,7 @@
 %%DATADIR%%/sounds/vm-unknown-caller.gsm
 %%DATADIR%%/sounds/vm-whichbox.gsm
 %%DATADIR%%/sounds/vm-youhave.gsm
+@exec mkdir -p %%DATADIR%%/sounds/priv-callerintros
 @dirrm %%DATADIR%%/sounds/priv-callerintros
 @dirrm %%DATADIR%%/sounds/phonetic
 @dirrm %%DATADIR%%/sounds/letters
@@ -755,7 +756,13 @@
 spool/asterisk/voicemail/default/1234/busy.gsm
 spool/asterisk/voicemail/default/1234/unavail.gsm
 @exec mkdir -p %D/log/asterisk/cdr-csv
+@exec mkdir -p %D/log/asterisk/cdr-custom
 @exec mkdir -p %D/spool/asterisk/voicemail/default/1234/INBOX
+@exec mkdir -p %D/spool/asterisk/dictate
+@exec mkdir -p %D/spool/asterisk/meetme
+@exec mkdir -p %D/spool/asterisk/monitor
+@exec mkdir -p %D/spool/asterisk/system
+@exec mkdir -p %D/spool/asterisk/tmp
 @dirrm spool/asterisk/dictate
 @dirrm spool/asterisk/meetme
 @dirrm spool/asterisk/monitor
How-To-Repeat: 	Try to build net/asterisk-addons and then remove packages.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-11-08 23:50:45 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sobomax

Over to maintainer
Comment 2 Boris B.Samorodov 2006-12-14 07:16:35 UTC
Hello, Maxim!

Have you any chance to look at this PR?
If you are busy now I can take care of it.

Thanks.
-- 
bsam
Comment 3 Boris Samorodov freebsd_committer freebsd_triage 2007-01-03 15:54:55 UTC
Responsible Changed
From-To: sobomax->bsam

I'll take care of the PR.
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-01-03 16:18:22 UTC
bsam        2007-01-03 16:18:06 UTC

  FreeBSD ports repository

  Modified files:
    net/asterisk         Makefile pkg-plist 
  Log:
  1. Fix a typo: dmsmgr.conf -> dnsmgr.conf.
  2. Create all needed directories (add @exec mkdir -p <dirs>) at
     pkg-plist file. This bug is seen only when the port is pkg_added/pkg_deletted
     by a port which depends on current port (ex. net/asterisk-addons).
  3. Bump PORTREVISION.
  
  PR:             105310
  Submitted by:   bsam (me)
  Approved by:    sobomax (maintainer timeout, 9 weeks)
  
  Revision  Changes    Path
  1.64      +1 -1      ports/net/asterisk/Makefile
  1.23      +8 -1      ports/net/asterisk/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Boris Samorodov freebsd_committer freebsd_triage 2007-01-03 16:21:44 UTC
State Changed
From-To: open->closed

Committed.