Bug 105722 - rc.subr dracd startup script syntax error
Summary: rc.subr dracd startup script syntax error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jeremy Chadwick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-21 18:40 UTC by Jeremy Chadwick
Modified: 2006-11-22 15:47 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Chadwick freebsd_committer freebsd_triage 2006-11-21 18:40:15 UTC
	It appears the default variable sets for dracd won't work
	due to a syntax error in the assignment.  Should be :- not -.

Fix: Apply below patch.



. %%RC_SUBR%%--oWSfYYYPffIsJjPNTksoPZ1UW6HDokl3wRjuM6jUWPgE5jf1
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- files/dracd.sh.in.orig    Thu Mar 23 07:53:09 2006
+++ files/dracd.sh.in Tue Nov 21 10:34:29 2006
@@ -13,8 +13,8 @@
 #
 # DO NOT CHANGE THESE DEFAULT VALUES HERE
 #
-dracd_enable=${dracd_enable-"NO"}
-dracd_flags=${dracd_flags-""}
+dracd_enable=${dracd_enable:-"NO"}
+dracd_flags=${dracd_flags:-""}
How-To-Repeat: 	Maybe try starting dracd without any dracd_xxx variables in rc.conf.
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2006-11-21 20:04:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->koitsu

Submitter is a committer. The port in question is not maintained. Submitter can 
commit the fix on his own.
Comment 2 dfilter service freebsd_committer freebsd_triage 2006-11-22 01:23:36 UTC
koitsu      2006-11-22 01:23:30 UTC

  FreeBSD ports repository

  Modified files:
    mail/drac            Makefile pkg-descr 
    mail/drac/files      dracd.sh.in 
  Removed files:
    mail/drac            pkg-message 
  Log:
  - Fixups for rc.subr dracd script (likely did not work without
    some dracd_xxx variables already defined in rc.conf)
  - Add new FTP mirror, since mirrors for this are few
  - Remove pkg-message; that notice has been around long enough :)
  - Grammatical fixes/wording in pkg-descr
  - Take over as maintainer of this port
  
  PR:             ports/105722
  Reviewed by:    philip
  Approved by:    philip
  
  Revision  Changes    Path
  1.25      +4 -6      ports/mail/drac/Makefile
  1.6       +13 -10    ports/mail/drac/files/dracd.sh.in
  1.4       +9 -9      ports/mail/drac/pkg-descr
  1.2       +0 -5      ports/mail/drac/pkg-message (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jeremy Chadwick freebsd_committer freebsd_triage 2006-11-22 15:43:00 UTC
State Changed
From-To: open->closed

Committed (and took over as maintainer).