Bug 105847 - [PATCH] multimedia/lsdvd: Fix segfault / make usable for dvd::rip
Summary: [PATCH] multimedia/lsdvd: Fix segfault / make usable for dvd::rip
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-25 19:40 UTC by Ulrich Spoerlein
Modified: 2006-12-02 13:10 UTC (History)
1 user (show)

See Also:

Attachments
lsdvd-0.16.patch (730 bytes, patch)
2006-11-25 19:40 UTC, Ulrich Spoerlein 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spoerlein 2006-11-25 19:40:10 UTC 
The "code output" subroutine handling arrays is flawed. It will segfault upon
first call. The following patch to ocode.c fixes this (at least, it is running
stable now and dvd::rip is happy with the output).

I included the original author, because this fix should be comitted upstream
too. Thanks!

Added file(s):
- files/patch-ocode.c

Port maintainer (pav@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-11-25 19:40:28 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

Over to maintainer
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2006-11-28 20:45:04 UTC 
State Changed
From-To: open->feedback

Can you provide me with an image where the error exhibits? I'm curious ..
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-02 12:49:25 UTC 
State Changed
From-To: feedback->open

Reproduction steps provided by submitter in private correspondence.
Comment 4 Pav Lucistnik freebsd_committer freebsd_triage 2006-12-02 13:06:43 UTC 
State Changed
From-To: open->closed

Committed, thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2006-12-02 13:07:00 UTC 
pav         2006-12-02 13:06:55 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/lsdvd     Makefile 
  Added files:
    multimedia/lsdvd/files patch-ocode.c 
  Log:
  - Fix runtime crash in machine readable output
  
  PR:             ports/105847
  Submitted by:   Ulrich Spoerlein <uspoerlein@gmail.com>
  
  Revision  Changes    Path
  1.13      +1 -0      ports/multimedia/lsdvd/Makefile
  1.1       +12 -0     ports/multimedia/lsdvd/files/patch-ocode.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"