Bug 105863 - module load error occurs lighttpd WITH_CML=YES
Summary: module load error occurs lighttpd WITH_CML=YES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frank J. Laszlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-26 11:10 UTC by Jun Mukai
Modified: 2006-12-13 14:40 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jun Mukai 2006-11-26 11:10:04 UTC
	When lighttpd is built WITH_CML=YES, the lighttpd cannot start because of load error of cml module.  This error is came from the mistake of the LUA_LIBS flag in Makefile.

Fix: 

.if defined(WITH_FAM)--XKKg4DYo7ppUU4BfRMkR2yLzay3MOnEZucU3DWHgen7CCZu4
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

diff -ru lighttpd.org/Makefile lighttpd/Makefile
--- lighttpd.org/Makefile       Sun Nov 26 20:02:49 2006
+++ lighttpd/Makefile   Wed Nov 22 20:59:21 2006
@@ -60,7 +60,7 @@
 .if defined(WITH_CML)
 USE_LUA=               yes
 CONFIGURE_ARGS+=       --with-lua
-CONFIGURE_ENV+=                LUA_CFLAGS="-I${LUA_INCDIR}" LUA_LIBS="-L${LUA_LIBDIR}"
+CONFIGURE_ENV+=                LUA_CFLAGS="-I${LUA_INCDIR}" LUA_LIBS="-L${LUA_LIBDIR} -llua"
 .endif
How-To-Repeat: 	# cd /usr/ports/www/lighttpd
	# make install WITH_CML=YES
        # vi /usr/local/etc/lighttpd.conf
        edit conf file to activate mod_cml
	# /usr/local/etc/rc.d/lighttpd.sh start
Comment 1 Stefan Walter freebsd_committer freebsd_triage 2006-11-26 12:08:17 UTC
Dear maintainer of www/lighttpd,

a PR has been submitted describing a problem with the port and is waiting
for your feedback. Please see [1] for the actual PR.

Regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/105863
Comment 2 Stefan Walter freebsd_committer freebsd_triage 2006-11-26 12:12:36 UTC
State Changed
From-To: open->feedback

Awaiting maintainer's feedback.
Comment 3 Frank J. Laszlo freebsd_committer freebsd_triage 2006-12-06 23:27:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->laszlof

I'll take it.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2006-12-13 12:45:18 UTC
State Changed
From-To: feedback->open

Maintainer was reset.
Comment 5 Marcus Alves Grando freebsd_committer freebsd_triage 2006-12-13 13:21:04 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2006-12-13 13:22:03 UTC
mnag        2006-12-13 13:20:51 UTC

  FreeBSD ports repository

  Modified files:
    www/lighttpd         Makefile 
  Log:
  - Fix CML option using -llua.
  
  PR:             105863
  Submitted by:   Jun MUKAI <mukai___jmuk.org>
  
  Revision  Changes    Path
  1.47      +1 -1      ports/www/lighttpd/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Frank J. Laszlo freebsd_committer freebsd_triage 2006-12-13 14:00:04 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Marcus Alves Grando wrote:
| Synopsis: module load error occurs lighttpd WITH_CML=YES
|
| State-Changed-From-To: open->closed
| State-Changed-By: mnag
| State-Changed-When: Wed Dec 13 13:21:04 UTC 2006
| State-Changed-Why:
| Committed. Thanks!
|
| http://www.freebsd.org/cgi/query-pr.cgi?pr=105863


Can we please verify the 'Responsible' section of the PR, I did not take
this PR just to have it hijacked by another committer. Thanks

- --
- -----------------------------
Frank J. Laszlo
laszlof@FreeBSD.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)

iQIVAwUBRYAHY61QwXwBI2DsAQhRsA/+LtDi/6FfC/Ezw6mA1P00VPL4UsIEt4e6
sPxnfhGxwr1dUqVzg3Vm9GLZs6Hh9MXpgAiG/GwdJx7VKeCBrG9w4KrjbyXBSyLh
RD16hdY2PIqyTaf1HYfqBoYUuEnMqD8bDrAFsPeidondtcG9z6WFGSyfzvvCtm6n
/QOHIw69D/lkP1hWv0A53iwt+1Kbwg4dGSEKV6lM53aDTyp312h2Ik6/Tn5g1QT/
PTDShCJE6uWWjVDbwB8nIQlPrmQJYcpOH18N5IkyUelFvzuRhsyqwdvGDFp8TkX1
yyoaKYfKOlEb57r1ZfJBdUIz/rLW8/PxZzDFSeZCnMPOFlgcw9OwbNGV9oACc7tN
4dhm3IyD+mivRMkUl20mlNkZPV1VArrFAQO+bLctRwDFRYoQZMH0fbhNUwwNiwx+
VxdUmQnbaj03dPGKchh01rPZYAcrZMqYY9hgTJJPlQ2I7Hpr5dewOySi2P7FlGPs
7efYpw+nD1MjbUPiPmux9fQY2Axxc1uNUSDbEzLDOxvQ7LB/g7aJfR7G9mGgle3a
euOG0dK+XObZB60gyw1dnQZf0jm90ybvvw55Rr8otkJS0mjRVi7NEAJUxuA28kBY
qDSfJL+uDCF29SmPwheY73o4xzFLvyccNulc+Hy40S3ejwDWTKK7QgeBCKXZ5CLN
3le5WAqS3IM=
=2041
-----END PGP SIGNATURE-----
Comment 8 Marcus Alves Grando freebsd_committer freebsd_triage 2006-12-13 14:13:17 UTC
Frank J. Laszlo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Marcus Alves Grando wrote:
> | Synopsis: module load error occurs lighttpd WITH_CML=YES
> |
> | State-Changed-From-To: open->closed
> | State-Changed-By: mnag
> | State-Changed-When: Wed Dec 13 13:21:04 UTC 2006
> | State-Changed-Why:
> | Committed. Thanks!
> |
> | http://www.freebsd.org/cgi/query-pr.cgi?pr=105863
> 
> 
> Can we please verify the 'Responsible' section of the PR, I did not take
> this PR just to have it hijacked by another committer. Thanks

I'm a new port maintainer of lighttpd. And theoretically i can't see any 
  problem to take pr's affecting my ports. Right?

Another point is after 14 days you can commit PR to maintainer timeout. 
Old maintainer are asked for approval in "Sun Nov 26 12:12:36 UTC 2006". 
Theoretically you could have commited in Nov, 10.

Regards

-- 
Marcus Alves Grando
marcus(at)corp.grupos.com.br  |  Grupos Internet S/A
   mnag(at)FreeBSD.org         |  FreeBSD.org
Comment 9 Mark Linimon 2006-12-13 14:16:15 UTC
On Wed, Dec 13, 2006 at 12:13:17PM -0200, Marcus Alves Grando wrote:
> I'm a new port maintainer of lighttpd. And theoretically i can't see any 
> problem to take pr's affecting my ports. Right?
> 
> Another point is after 14 days you can commit PR to maintainer timeout. 
> Old maintainer are asked for approval in "Sun Nov 26 12:12:36 UTC 2006". 
> Theoretically you could have commited in Nov, 10.

Yes, but since the PR was already assigned to someone else, it would have
been more polite to ask.

mcl
Comment 10 Marcus Alves Grando freebsd_committer freebsd_triage 2006-12-13 14:27:41 UTC
Mark Linimon wrote:
> On Wed, Dec 13, 2006 at 12:13:17PM -0200, Marcus Alves Grando wrote:
>> I'm a new port maintainer of lighttpd. And theoretically i can't see any 
>> problem to take pr's affecting my ports. Right?
>>
>> Another point is after 14 days you can commit PR to maintainer timeout. 
>> Old maintainer are asked for approval in "Sun Nov 26 12:12:36 UTC 2006". 
>> Theoretically you could have commited in Nov, 10.
> 
> Yes, but since the PR was already assigned to someone else, it would have
> been more polite to ask.

Sorry. I will ask.

Btw. If that's happened to me, i don't care, because it's too increase 
FreeBSD ports. ;)

Regards

> 
> mcl

-- 
Marcus Alves Grando
marcus(at)corp.grupos.com.br  |  Grupos Internet S/A
   mnag(at)FreeBSD.org         |  FreeBSD.org
Comment 11 Frank J. Laszlo freebsd_committer freebsd_triage 2006-12-13 14:27:41 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Marcus Alves Grando wrote:
| Frank J. Laszlo wrote:

|
| I'm a new port maintainer of lighttpd. And theoretically i can't see any
|  problem to take pr's affecting my ports. Right?
|
| Another point is after 14 days you can commit PR to maintainer timeout.
| Old maintainer are asked for approval in "Sun Nov 26 12:12:36 UTC 2006".
| Theoretically you could have commited in Nov, 10.
|
| Regards
|

There is no audit trail (other than viewing the commit diff's) that you
were taking maintainership of this port. In the future I would suggest
at least pinging the responsible party letting them know your
intentions. Also making a note of this in the PR would also be helpful.
A system without checks and balances is just chaos.

- --
- -----------------------------
Frank J. Laszlo
laszlof@FreeBSD.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)

iQIVAwUBRYAN3a1QwXwBI2DsAQh38w//e+PxkNlUpo9Rt2+AL5FEpjzpvS2irn3H
L12N+8eO7TZ0/OxZUaF54ZO38AkI11ZdWT6SG2eWRostJyKZDmhFHqSMczmOHP7X
XEaMup2fQ4hMpZ/bQmmm/g0q9W6aHHn03ugcgW22FQXS9xLIWlcVam0xpjPpLXtj
Y6Fx6l4ROA166DDiykw0cRJlXbELHvEOJeXV51VGCKisALVqF8Nc/4eTYRaRt0vh
QSSnqr0E0ymh+OjvfzkqaZwQhmmMjssqIxMF4BgVd6ksc7x6nVFASL86CUy4fTBW
f+S2WXVVCvNYbpiO0/UJWaIVUzVck7AbQDnGFgdGId/AAf04djiSnFly5+Bo3ukU
Oodq0ceqrqajznEzS66BgIY/ljrTXP0IBjRTSc9uoVQYs2m6F/4Gjydp7XGO4LjY
4iC1fGjpwXibk+1v0Joj7wlW3PEUDxcGX1OaYWxBtmozCKtJgeiFmMtkkv5h/S0a
7KiaB982rEDpeEFV2mTx3M+1W8SNA9cC1SfLUo6zjt+39Cv9UI9pcQ8CDTcfiZX5
oyF+icf4i7CH6ld0fn7IyG+66WmvQTcE0382Nj3y8gBjCWIfYIgvVakR14n/iG/Z
CspTwWmAgyOspCMnCaGkARqoYCiqIx/kQ/1ZMUnXteWMk3LCstsV0r3aNHTvhh+C
+KkbHba6LkA=
=wlDZ
-----END PGP SIGNATURE-----
Comment 12 Marcus Alves Grando freebsd_committer freebsd_triage 2006-12-13 14:30:17 UTC
Frank J. Laszlo wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
> 
> Marcus Alves Grando wrote:
> | Frank J. Laszlo wrote:
> 
> |
> | I'm a new port maintainer of lighttpd. And theoretically i can't see any
> |  problem to take pr's affecting my ports. Right?
> |
> | Another point is after 14 days you can commit PR to maintainer timeout.
> | Old maintainer are asked for approval in "Sun Nov 26 12:12:36 UTC 2006".
> | Theoretically you could have commited in Nov, 10.
> |
> | Regards
> |
> 
> There is no audit trail (other than viewing the commit diff's) that you
> were taking maintainership of this port. In the future I would suggest
> at least pinging the responsible party letting them know your
> intentions. Also making a note of this in the PR would also be helpful.
> A system without checks and balances is just chaos.

I agree. And sorry for the problem caused.

Regards

-- 
Marcus Alves Grando
marcus(at)corp.grupos.com.br  |  Grupos Internet S/A
   mnag(at)FreeBSD.org         |  FreeBSD.org