mp4box is a mp4 container merge tool from gpac. Documentation here: http://gpac.sourceforge.net/doc_mp4box.php WWW: http://gpac.sourceforge.net/
Responsible Changed From-To: freebsd-ports-bugs->gabor Take.
Dear Submitter, this port is not quite good in some aspects: - there are lots of blank line in the Makefile and patch-Makefile - PORTEPOCH should not be used here - we don't have USE_CONFIGURE, just HAS_CONFIGURE and GNU_CONFIGURE, which should only be defined if the port has a configure script - the dist Makefile can be patched directly instead of removing the old one and adding the new one, this makes the port simpler - PLIST_BIN should be used instead of a pkg-plist file if the port only installs few files - tabs should be used instead of spaces where possible Could you fix the above issues, please? A good starting point would be Porter's Handbook from the FreeBSD website: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/index.html Also, please check your port with sysutils/portlint before submitting it, you can find more information about this in PH as well. Thanks for your effort to working on this port. I'm looking forward to receive a fix from you. :) Regards, Gabor
State Changed From-To: open->feedback Ask for submitter fix.
State Changed From-To: feedback->closed Feedback timeout. If you feel like continue working on this new port, please feel free to submit a follow-up to this PR. Regards, Gabor
State Changed From-To: closed->open Feedback received.
State Changed From-To: open->feedback The shell archive has been corrupted by your mail client, could you resend it in a private mail to me, or (more preferably) upload it to somewhere, please? Regards, Gabor
gabor 2007-02-06 12:33:43 UTC FreeBSD ports repository Modified files: multimedia Makefile Added files: multimedia/gpac-mp4box Makefile distinfo pkg-descr multimedia/gpac-mp4box/files patch-Makefile Log: mp4box is a mp4 container merge tool from gpac. Documentation here: http://gpac.sourceforge.net/doc_mp4box.php WWW: http://gpac.sourceforge.net/ PR: ports/106273 Submitted by: Pascal Vizeli <pvizeli at yahoo.de> Approved by: erwin (mentor) Revision Changes Path 1.208 +1 -0 ports/multimedia/Makefile 1.1 +24 -0 ports/multimedia/gpac-mp4box/Makefile (new) 1.1 +3 -0 ports/multimedia/gpac-mp4box/distinfo (new) 1.1 +92 -0 ports/multimedia/gpac-mp4box/files/patch-Makefile (new) 1.1 +6 -0 ports/multimedia/gpac-mp4box/pkg-descr (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Port committed with slight modifications, thanks! CC, CFLAGS and PREFIX should be respected, this means we should give the opportunity to the user to override these. I've modified patch-Makefile to do this. FreeBSD 4.X are not suppoted any more, thus we don't have to add BROKEN for <5.X.