Bug 106794 - Port multimedia/pwcbsd is out of date with latest usb_port.h changes
Summary: Port multimedia/pwcbsd is out of date with latest usb_port.h changes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Coleman Kane
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-15 22:10 UTC by Coleman Kane
Modified: 2006-12-17 01:40 UTC (History)
0 users

See Also:


Attachments
file.diff (8.58 KB, patch)
2006-12-15 22:10 UTC, Coleman Kane
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Coleman Kane freebsd_committer freebsd_triage 2006-12-15 22:10:08 UTC
The port multimedia/pwcbsd has become unbuildable due to the changes applied to sys/dev/usb/usb_port.h to remove a bunch of compatibility #defines, such as USBDEVNAME(x) and USBBASEDEV. 

This port was overdue for a cleanup anyhow.

Fix: The following patch adds a set of patch files to the files/ subdir that properly replace a bunch of printf statements with canonical device_printf's that do the same basic thing (but more correctly).

In addition, other defines have been manually resolved by me.

This fix also is tested working under RELENG_6 and should be supported by all releases that originally supported this port (not a -CURRENT only patchset). As stated, these breakages were only exposed when deprecated compatibility code was removed from the USB system.

Patch attached with submission follows:
How-To-Repeat: Install -CURRENT.

cd /usr/ports/multimedia/pwcbsd
sudo make

.. watch it die.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-15 22:10:27 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cokane

Submitter has GNATS access
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-15 22:10:34 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 dfilter service freebsd_committer freebsd_triage 2006-12-16 05:50:29 UTC
cokane      2006-12-16 05:50:15 UTC

  FreeBSD ports repository (src committer)

  Modified files:
    multimedia/pwcbsd    Makefile 
  Added files:
    multimedia/pwcbsd/files patch-pwc-ctrl.c patch-pwc.c 
                            patch-pwc.h 
  Log:
  Commit of fixes that make this buildable once again after Rev. 1.82 of
  src/sys/dev/usb/usb_port.h hacked off some deprecated compatibilty macros.
  
  A number of manually designed device printf statements were replaced with
  the appropriate calls to device_printf(9). In addition, did a find/replace
  of other removed macros with the previous definitions from that file.
  
  I don't have a camera so I don't know the operative status of this port
  under -CURRENT yet.
  
  PR:             ports/106794
  
  Revision  Changes    Path
  1.9       +1 -0      ports/multimedia/pwcbsd/Makefile
  1.1       +14 -0     ports/multimedia/pwcbsd/files/patch-pwc-ctrl.c (new)
  1.1       +196 -0    ports/multimedia/pwcbsd/files/patch-pwc.c (new)
  1.1       +11 -0     ports/multimedia/pwcbsd/files/patch-pwc.h (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Coleman Kane freebsd_committer freebsd_triage 2006-12-17 01:38:36 UTC
State Changed
From-To: feedback->closed

Close this myself, as the commit has fixed the problem.