Bug 106868 - [ports/ftp/lftp] Fix "make package" if WITHOUT_NLS is defined.
Summary: [ports/ftp/lftp] Fix "make package" if WITHOUT_NLS is defined.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-18 13:30 UTC by Sunpoet Po-Chuan Hsieh
Modified: 2007-01-19 22:20 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (1.89 KB, patch)
2006-12-18 13:30 UTC, Sunpoet Po-Chuan Hsieh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sunpoet Po-Chuan Hsieh 2006-12-18 13:30:27 UTC
1. Clean up MASTER_SITES. Only 4 of 10 is available.
2. Fix make package if WITHOUT_NLS is defined.
3. Use dirrmtry instead of dirrm.
Maintainer is cc'd.

How-To-Repeat: # cd /usr/ports/ftp/lftp
# make WITHOUT_NLS=YES package
===>  Building package for lftp-3.5.6_1
Creating package /usr/ports/packages/All/lftp-3.5.6_1.tbz
Registering depends: expat-2.0.0_1 libiconv-1.9.2_2 readline-5.2.
Creating bzip'd tar ball in '/usr/ports/packages/All/lftp-3.5.6_1.tbz'
tar: share/locale/de/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/es/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/fr/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/it/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/ja/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/ko/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/pl/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/pt_BR/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/ru/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/zh_CN/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
tar: share/locale/zh_TW/LC_MESSAGES/lftp.mo: Cannot stat: No such file or directory
pkg_create: make_dist: tar command failed with code 256
*** Error code 1

Stop in /usr/ports/ftp/lftp.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2006-12-18 13:30:57 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2006-12-29 00:02:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

I'll take it.
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-01-16 09:52:50 UTC
On Mon, 18 Dec 2006 21:26:30 +0800 (CST)
Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net> wrote:

> 3. Use dirrmtry instead of dirrm.


Why ?

> Maintainer is cc'd.


I'll commit via maintainer-timeout.


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

Ferengi Rule of Acquisition #58:
	There is no substitute for success.
		-- ST: Legends of the Ferengi

Comment 4 Dmitry A. Yanko 2007-01-18 14:24:46 UTC
Ion-Mihai IOnut Tetcu пиÑеÑ:
> Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net> wrote:
>> 3. Use dirrmtry instead of dirrm.
> Why ?
>> Maintainer is cc'd.
> I'll commit via maintainer-timeout.
I have no objections, if patch tested. I can't test it just now.
But, i don't agree to remove mirrors with /old subfolders from mirrors list.
Comment 5 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-01-19 06:40:23 UTC
On Thu, 18 Jan 2007 16:24:46 +0200
"Dmitry A. Yanko" <fm@cross-road.org.ua> wrote:

> >> Maintainer is cc'd.
> > I'll commit via maintainer-timeout.
> I have no objections, if patch tested. I can't test it just now.


OK.

> But, i don't agree to remove mirrors with /old subfolders from
> mirrors list.


Why ? From what I see the DISTFILES isn't in any of old/ dirs ? Do they
move it there from time to time ? Then maybe we should reorder the
MASTER_SITES and put the one with old/ at the end ?


-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"

BOFH excuse #142:
new guy cross-connected phone lines with ac power bus

Comment 6 Dmitry A. Yanko 2007-01-19 10:29:31 UTC
Ion-Mihai IOnut Tetcu пиÑеÑ:
>> But, i don't agree to remove mirrors with /old subfolders from
>> mirrors list.
> Why ? From what I see the DISTFILES isn't in any of old/ dirs ? Do they
> move it there from time to time ? Then maybe we should reorder the
> MASTER_SITES and put the one with old/ at the end ?

Yes, from time to time old distfiles moved into /old subfolder.
Sometimes, previous version
moved into /old so rapidly, that some users, that installs lftp, obtains
error. It takes a time to
update lftp's port. I added /old to MASTER_SITES to prevent such situations.
Yes, we can reorder MASTER_SITES and put the one with old/ at the end,
but then fetching will be faster in one case, and slowly in other.
No one asks for this before. If you think, that reorder will makes
fetching better, reorder it.
Comment 7 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-01-19 13:18:13 UTC
State Changed
From-To: feedback->open

we have all the maintainer-approvals we need
Comment 8 dfilter service freebsd_committer freebsd_triage 2007-01-19 22:16:23 UTC
itetcu      2007-01-19 22:16:18 UTC

  FreeBSD ports repository

  Modified files:
    ftp/lftp             pkg-plist 
  Log:
  Fix plist when WITHOUT_NLS is defined.
  
  PR:             ports/106868
  Submitted by:   Sunpoet Po-Chuan Hsieh
  Approved by:    maintainer (only for the part commited).
  
  Revision  Changes    Path
  1.27      +11 -11    ports/ftp/lftp/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-01-19 22:16:56 UTC
State Changed
From-To: open->closed

The part approved by maintainer commited. Thanks!