update www/rt36 to 3.6.3 release
Responsible Changed From-To: freebsd-ports-bugs->bsam Take.
Hello Vivek! Thanks for taking care of the port. 1. While testing the patch at my tinderbox I've got an error: ----- ====================<phase 7: make package>==================== ===> rt-3.6.3 may not be packaged: Executes scripts in post-install phase. Deleting rt-3.6.3 pkg_delete: unable to completely remove directory '/usr/local/rt3' pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?) ================================================================ === Checking filesystem state list of extra files and directories in / (not present before this port was installed but present after it was deinstalled) 402245 4 drwxr-xr-x 3 root wheel 512 Dec 22 15:35 usr/local/rt3 402246 4 drwxr-xr-x 2 root rt 512 Dec 22 15:35 usr/local/rt3/etc ----- The following line at pkg-plist caused it: ----- @dirrmtry %%RT_PATH%%/etc ----- The command @dirrmtry is expanded by bsd.ports.mk (not absolute path is expected here): ----- PLIST_REINPLACE_DIRRMTRY=s!^@dirrmtry \(.*\)!@unexec rmdir %D/\1 2>/dev/null || true! ----- Hence the resulting line becomes: ----- @unexec rmdir %D//usr/local/rt3/etc 2>/dev/null || true ----- For more information about special % sequences you may read at pkg_create(1) and for more pkg-plist examples: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-cleaning.html I propose to change that line at pkg-plist to (it works fine): ----- @dirrmtry %%RTPLIST%%/etc ----- 2. When testing the port I found out that one of it's dependencies can't be fetched (a new version is available). I filed the PR: http://www.freebsd.org/cgi/query-pr.cgi?pr=107099 I don't think that the new version of devel/p5-Class-Accessor may cause any errors, but you may consider testing it. 3. Portlint (devel/portlint) shows one FATAL error at Makefile: ----- FATAL: Makefile: [154]: contiguous blank lines (> 1 lines) found. ----- I'll delete one blank line when committing. Well, so far so good. I ask you approval to those changes. PS. If you want to do some polishing to the port in the future, "portlint -a" may give you some tips. ;-) WBR -- Boris Samorodov (bsam) Research Engineer, http://www.ipt.ru Telephone & Internet SP FreeBSD committer, http://www.FreeBSD.org The Power To Serve
On Dec 22, 2006, at 11:52 AM, Boris Samorodov wrote: > Hello Vivek! > > > Thanks for taking care of the port. [ ... ] > Well, so far so good. I ask you approval to those changes. > I approve. Thanks!
bsam 2006-12-22 17:07:38 UTC FreeBSD ports repository Modified files: www/rt36 Makefile distinfo pkg-message pkg-plist www/rt36/files patch-Makefile_in Log: . update to new version 3.6.3; [1] . fix pkg-plist; [2] . remove extra blank line from Makefile. [2] PR: 107037 [1] Submitted by: Vivek Khera <vivek at khera.org> (maintainer) [1] Approved by: Vivek Khera <vivek at khera.org> (maintainer) [2] Revision Changes Path 1.58 +7 -6 ports/www/rt36/Makefile 1.25 +6 -6 ports/www/rt36/distinfo 1.2 +19 -6 ports/www/rt36/files/patch-Makefile_in 1.6 +2 -1 ports/www/rt36/pkg-message 1.18 +11 -2 ports/www/rt36/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed with approved changes, thanks!