Bug 107394 - [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
Summary: [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ion-Mihai "IOnut" Tetcu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-01 11:50 UTC by Ulrich Spoerlein
Modified: 2007-01-05 00:30 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Spoerlein 2007-01-01 11:50:17 UTC
The OPTIONS framework is flawed wrt. to BATCH mode. There are around 600
instances where wrong checks are performed. For a general fix see ports/105147

This is the same problem as
http://www.freebsd.org/cgi/query-pr.cgi?pr=107349

Port maintainer (itetcu@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77

Fix: 

The pre-everything:: target already has this right.--5ZsBs7NvQTVPTpHPi3SKvH18iR2j6Tmn0kdY3uNc3aqMFB8A
Content-Type: text/plain; name="tinderbox-2.3.4_2.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="tinderbox-2.3.4_2.patch"

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/tinderbox/Makefile,v
retrieving revision 1.26
diff -u -p -u -r1.26 Makefile
--- Makefile	17 Dec 2006 19:07:47 -0000	1.26
+++ Makefile	30 Dec 2006 17:48:11 -0000
@@ -31,7 +31,7 @@ MAN1=		tc-configCcache.1 tc-configDistfi
 
 .include <bsd.port.pre.mk>
 
-.if defined(WITHOUT_PGSQL) && defined(WITHOUT_MYSQL)
+.if !defined(WITH_PGSQL) && defined(WITHOUT_MYSQL)
 IGNORE=	is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL
 .endif
How-To-Repeat: % cd /usr/ports/misc/tinderbox
% make __MAKE_CONF=/dev/null -DBATCH -DWITH_PGSQL -DWITHOUT_MYSQL 
===>  tinderbox-2.3.4_2 is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL.
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-01-01 11:50:33 UTC
Responsible Changed
From-To: freebsd-ports-bugs->itetcu

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-01-05 00:24:47 UTC
itetcu      2007-01-05 00:24:44 UTC

  FreeBSD ports repository

  Modified files:
    misc/tinderbox       Makefile 
  Log:
  Fix OPTIONS handling.
  
  PR:             ports/107394
  Submitted by:   Ulrich Spoerlein
  
  Revision  Changes    Path
  1.27      +1 -1      ports/misc/tinderbox/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Ion-Mihai "IOnut" Tetcu freebsd_committer freebsd_triage 2007-01-05 00:24:57 UTC
State Changed
From-To: open->closed

Committed. Thanks!