At our site, having syslog.sample put into /usr/local/etc/logrotate.d means we have to add 'tabooext + .sample' to our conf file which sends error messages through cron emails about ignoring the aforementioned example file. If syslog.sample were put into /usr/local/share/examples/logrotate then we wouldn't have to take special measures in our cluster installation procedure; obviously for one or two machines this irritation would never arise. Fix: Submitting two patches for the Makefile and the pkg-plist. Makefile: 34a35 > @${MKDIR} ${PREFIX}/share/examples/logrotate 37c38 < @${INSTALL_DATA} ${FILESDIR}/syslog.sample ${PREFIX}/etc/logrotate.d/ --- > @${INSTALL_DATA} ${FILESDIR}/syslog.sample ${PREFIX}/share/examples/logrotate/ pkg-plist: 3c3,4 < etc/logrotate.d/syslog.sample --- > share/examples/logrotate/syslog.sample > @dirrm share/examples/logrotate How-To-Repeat: Include /usr/local/etc/logrotate.d in your logrotate.conf.
State Changed From-To: open->feedback Awaiting maintainer's feedback.
State Changed From-To: feedback->open Maintainer timeout.
Responsible Changed From-To: freebsd-ports-bugs->gabor Take.
Hi, Sorry, there was a failure with my email system in late January. I'm fine with this change, it makes more sense. Regards: -- Balazs Nagy
gabor 2007-02-17 20:56:56 UTC FreeBSD ports repository Modified files: sysutils/logrotate Makefile pkg-plist Log: - Install the sample file to EXAMPLESDIR - Bump PORTREVISION PR: ports/108466 Submitted by: Ian Tegebo <yontege@rescomp.berkeley.edu> Approved by: Balazs Nagy <js@iksz.hu> (maintainer), erwin (mentor, implicit) Revision Changes Path 1.22 +3 -3 ports/sysutils/logrotate/Makefile 1.2 +2 -2 ports/sysutils/logrotate/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks! Note, that the plist change also requires a PORTREVISION bump, and you should use the EXAMPLESDIR macro for reffering to ${PREFIX}/share/examples/${PORTNAME}. I fixed these in the port before committing.