Bug 108897 - /usr/ports/mail/cone must depend devel/ncurse
Summary: /usr/ports/mail/cone must depend devel/ncurse
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Norikatsu Shigemura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-07 18:20 UTC by NAKAGAWA Tsuneo
Modified: 2007-02-11 19:20 UTC (History)
0 users

See Also:


Attachments
patch-to-cone-ports.tar.bz2 (3.67 KB, application/x-bzip)
2007-02-11 15:11 UTC, NAKAGAWA Tsuneo
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description NAKAGAWA Tsuneo 2007-02-07 18:20:19 UTC
cone is multilanguage MUA.

It work on UTF-8 environment, and it depend on wide character support ncurse. ( see http://www.courier-mta.org/cone/readme.html ).

in current port, cone can work at LANG=us_en.UTF-8 only. and can't display wide characters.

mentener have to depend devel/ncurses and must can compile with this.

Fix: 

I'm trying now.
How-To-Repeat: Only install by ports, display only ascii.

After install devel/ncurses, Can't compile.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-07 18:20:39 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Larry Rosenman freebsd_committer freebsd_triage 2007-02-07 18:25:13 UTC
I don't have a good utf-8 setup.  If you come up with a fix/patch, I'll
approve.



-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 512-248-2683             E-Mail: ler@lerctr.org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893

-----Original Message-----
From: owner-freebsd-ports-bugs@freebsd.org
[mailto:owner-freebsd-ports-bugs@freebsd.org] On Behalf Of NAKAGAWA Tsuneo
Sent: Wednesday, February 07, 2007 12:18 PM
To: freebsd-gnats-submit@FreeBSD.org
Subject: ports/108897: /usr/ports/mail/cone must depend devel/ncurse


>Number:         108897
>Category:       ports
>Synopsis:       /usr/ports/mail/cone must depend devel/ncurse
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 07 18:20:19 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     NAKAGAWA Tsuneo
>Release:        5-stable
>Organization:
private
>Environment:
5.5-STABLE FreeBSD 5.5-STABLE #5: Sun Nov 26 13:49:35 JST 2006
root@main.kikansha.jp:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
cone is multilanguage MUA.

It work on UTF-8 environment, and it depend on wide character support
ncurse. ( see http://www.courier-mta.org/cone/readme.html ).

in current port, cone can work at LANG=us_en.UTF-8 only. and can't display
wide characters.

mentener have to depend devel/ncurses and must can compile with this. 

>How-To-Repeat:
Only install by ports, display only ascii.

After install devel/ncurses, Can't compile. 
>Fix:
I'm trying now.
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
freebsd-ports-bugs@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs
To unsubscribe, send any mail to
"freebsd-ports-bugs-unsubscribe@freebsd.org"
Comment 3 Larry Rosenman freebsd_committer freebsd_triage 2007-02-07 18:28:47 UTC
I responded to the PR.  I don't have a good way to test UTF-8 stuff, so if
the submitter, or one of the ports-folks has a good patch, feel free to
commit it.

Thanks,
LER


-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 512-248-2683             E-Mail: ler@lerctr.org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893

-----Original Message-----
From: Edwin Groothuis [mailto:edwin@FreeBSD.org] 
Sent: Wednesday, February 07, 2007 12:21 PM
To: ler@lerctr.org
Subject: Re: ports/108897: /usr/ports/mail/cone must depend devel/ncurse

Maintainer of mail/cone,

Please note that PR ports/108897 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/108897

-- 
Edwin Groothuis
edwin@FreeBSD.org
Comment 4 NAKAGAWA Tsuneo 2007-02-07 18:40:14 UTC
On 2007-02-08 03:25(JST), Larry Rosenman wrote:
> I don't have a good utf-8 setup.  If you come up with a fix/patch, I'll
> approve.

OK. I try in this week. Please wait. and keep not close this send-pr.
Thank you.

-- 
     T.Nakagawa ( mailto:yaemon@kikansha.jp )
     http://www.kikansha.jp/~yaemon/
Comment 5 NAKAGAWA Tsuneo 2007-02-11 15:11:06 UTC
Hello, I'm T.Nakagawa who reported this send-pr.
I think fix it. For both use ascii MUA or multilanguage MUA.

Please blush up pre-extract comment ( or another place move )
from my broken English to native English.

On 2007-02-08 03:40 (JST), Tsuneo Nakagawa wrote:
> On 2007-02-08 03:25(JST), Larry Rosenman wrote:
>> I don't have a good utf-8 setup.  If you come up with a fix/patch, I'll
>> approve.
> 
> OK. I try in this week. Please wait. and keep not close this send-pr.
> Thank you.
> 


-- 
     T.Nakagawa ( mailto:yaemon@kikansha.jp )
     http://www.kikansha.jp/~yaemon/
Comment 6 Larry Rosenman freebsd_committer freebsd_triage 2007-02-11 18:36:45 UTC
I've taken Tsuneo Nakagawa's patch, and updated it appropriately.  Please use 
this patch (I don't think his(her?) plist changes are necessary).

Please apply

--- /usr/ports/mail/cone/Makefile	Thu Dec 21 20:51:11 2006
+++ Makefile	Sun Feb 11 12:32:35 2007
@@ -7,7 +7,7 @@

  PORTNAME=	cone
  PORTVERSION=	0.69
-PORTREVISION=	2
+PORTREVISION=	3
  CATEGORIES=	mail
  # This is for beta versions, leave it in please:
  #MASTER_SITES=	http://www.courier-mta.org/beta/${PORTNAME}/ \
@@ -31,15 +31,41 @@
  USE_BZIP2=	yes
  USE_PERL5=	yes
  USE_GMAKE=	yes
+CPPFLAGS=	-I${LOCALBASE}/include
  GNU_CONFIGURE=	yes
  CONFIGURE_ARGS=	-C --without-db --with-certdb --prefix=${PREFIX} --exec-prefix=${PREFIX}

  CONFIGURE_ENV=	REHASH="${PERL} ${SCRIPTDIR}/c_rehash" LDFLAGS=-L${LOCALBASE}/lib \
-		CPPFLAGS=-I${LOCALBASE}/include
+		CPPFLAGS="${CPPFLAGS}"
  CONFIGURE_TARGET=	--build=${ARCH}-portbld-freebsd${OSREL}
  MAN1=		cone.1 leaf.1 mailtool.1
  INSTALL_TARGET=	install-strip

+.include <bsd.port.pre.mk>
+
+.if ${OSVERSION} < 502010
+IGNORE=		not supported on FreeBSD versions before 5.2.1-RELEASE
+.endif
+
+.if exists(${LOCALBASE}/include/ncurses/ncurses.h) || defined(WITH_NCURSESW)
+CPPFLAGS+=	-I${WRKDIR} -D_XOPEN_SOURCE_EXTENDED
+LIB_DEPENDS+=	ncursesw.5:${PORTSDIR}/devel/ncurses
+
+post-extract:
+		${MKDIR} ${WRKDIR}/ncursesw
+		${LN} -s ${LOCALBASE}/include/ncurses/ncurses.h ${WRKDIR}/ncursesw/curses.h
+.else
+
+ONFIGURE_ARGS+=      --disable-unicode
+
+pre-extract:
+	 @${ECHO_CMD} ""
+	 @${ECHO_CMD} "to use multilanguage ( unicode ) MUA, please set WITH_NCURSESW"
+	 @${ECHO_CMD} "or install devel/ncurses first"
+	 @${ECHO_CMD} ""
+
+.endif
+
  post-install:
  		${INSTALL_SCRIPT} ${WRKSRC}/sysconftool ${PREFIX}/sbin/cone-sysconftool
  		PKG_PREFIX=${PREFIX} ${SH} pkg-install ${PORTNAME} POST-INSTALL
@@ -47,12 +73,6 @@
  .if !defined(NOPORTDOCS)
  		${MKDIR} ${DOCSDIR}
  		${INSTALL_MAN} ${WRKSRC}/ChangeLog ${DOCSDIR}
-.endif
-
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} < 502010
-IGNORE=		not supported on FreeBSD versions before 5.2.1-RELEASE
  .endif

  .include <bsd.port.post.mk>

-- 
Larry Rosenman                     http://www.lerctr.org/~ler
Phone: +1 512-248-2683                 E-Mail: ler@lerctr.org
US Mail: 430 Valona Loop, Round Rock, TX 78681-3893
Comment 7 Norikatsu Shigemura freebsd_committer freebsd_triage 2007-02-11 18:48:35 UTC
State Changed
From-To: feedback->analyzed

I'll handle this. 


Comment 8 Norikatsu Shigemura freebsd_committer freebsd_triage 2007-02-11 18:48:35 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nork

I'll handle this.
Comment 9 dfilter service freebsd_committer freebsd_triage 2007-02-11 19:19:25 UTC
nork        2007-02-11 19:19:20 UTC

  FreeBSD ports repository

  Modified files:
    mail/cone            Makefile 
  Log:
  o Add support UTF-8 with ncursesw.
  o No more required LANG=UTF8 without ncursesw.
  o Bump PORTREVISION, accordingly.
  
  PR:             ports/108897
  Submitted by:   Tsuneo Nakagawa <yaemon@kikansha.jp>
  Approved by:    Larry Rosenman <ler@lerctr.org> (maintainer)
  
  Revision  Changes    Path
  1.26      +28 -8     ports/mail/cone/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Norikatsu Shigemura freebsd_committer freebsd_triage 2007-02-11 19:19:33 UTC
State Changed
From-To: analyzed->closed

Committed, thanks!