This patch tries to solve the problems in kioslave/media which are listed below: 1. Correct ejecting of mounted volumes (unmount before eject). 2. Mounting of removable media drives (such as CD-ROM drives) listed in /etc/fstab (removes checking linux's "user" mount option). 3. Polling floppy drives over the mount state (FreeBSD HAL doesn't do this). 4. Informing the fileview when HAL notifies that mounting is completed. 5. Mounting cdrom volume in locale charset.
Responsible Changed From-To: freebsd-ports-bugs->kde Over to maintainer
Thanks for your continued work on this! There is a problem with the charset mount option however: KDE/Qt's names for encodings don't always match FreeBSD's. For instance with LANG=de_DE.ISO8859-15, KGlobal::locale()->encoding() yields "ISO 8859-15", but mount_cd9660 only understands ISO8859-15, ISO-8859-15 or ISO_8859-15. Do you want to work on that some more or should I go ahead and commit the patch without the charset conversion?
lofi 2007-02-10 03:32:52 UTC FreeBSD ports repository Modified files: x11/kdebase3 Makefile x11/kdebase3/files extrapatch-kioslave_media_mediamanager-halbackend.cpp Added files: x11/kdebase3/files extrapatch-kioslave_media_mediamanager-halbackend.h patch-kioslave_media_mediamanager-fstabbackend.cpp patch-kioslave_media_mounthelper-kio_media_mounthelper.cpp Log: Fix various problems in the media kioslave: - Correct ejecting of mounted volumes (unmount before eject). - Mounting of removable media drives (such as CD-ROM drives) listed in /etc/fstab (removes checking linux's "user" mount option). - Polling floppy drives over the mount state (FreeBSD HAL doesn't do this). - Informing the fileview when HAL notifies that mounting is completed. - Mounting cdrom volume in locale charset. Note: Requires cd9660_iconv! PR: ports/108949 Submitted by: Maxim Samsonov <xors@sendmail.ru> - Disable polling of nfs shares in the fstabbackend. Mounting/Unmounting is broken and the polling can cause DBus aborts that take kded with them. Revision Changes Path 1.190 +3 -2 ports/x11/kdebase3/Makefile 1.3 +175 -24 ports/x11/kdebase3/files/extrapatch-kioslave_media_mediamanager-halbackend.cpp 1.1 +33 -0 ports/x11/kdebase3/files/extrapatch-kioslave_media_mediamanager-halbackend.h (new) 1.6 +10 -0 ports/x11/kdebase3/files/patch-kioslave_media_mediamanager-fstabbackend.cpp (new) 1.1 +32 -0 ports/x11/kdebase3/files/patch-kioslave_media_mounthelper-kio_media_mounthelper.cpp (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!