The patch by Daniel O'Connor committed to audio/amarok on 18th January and included in Amarok's 1.4.5 release that was supposed to fix FAT file system detection on FreeBSD actually breaks it in some cases. When a FAT partition is mounted via fstab entry or mount_msdosfs, KMountPoint may report its type as "msdosfs". However, when mounting through HAL and media:/ (the officially supported method of mounting removable drives under KDE), the file system type KMountPoint is "vfat", even under FreeBSD. Thus, Daniel's patch fixes the detection of manually mounted FAT partitions but breaks the probably more common case of mounting through HAL. The attached patch fixes this behavior by flagging both "msdosfs" and "vfat" as FAT. The upstream bug report is: http://bugs.kde.org/show_bug.cgi?id=141614 Fix: Drop the following patch into /usr/ports/audio/amarok/files: How-To-Repeat: * Mount a removable FAT partition (thumb drive, MP3 player) through media:/ * Attempt to transfer a fine named for example "test:file.mp3" to the drive using Amarok
Responsible Changed From-To: freebsd-ports-bugs->mich Over to maintainer
mich 2007-03-07 16:17:21 UTC FreeBSD ports repository Modified files: audio/amarok pkg-plist Added files: audio/amarok/files patch-amarok_src_mediadevice_generic_genericmediadevice.cpp Log: - fix PLIST after libmtp support is working again - Fix detection of msdosfs/vfat [1] PR: ports/109111 [1] Submitted by: Bartosz Fabianowski <freebsd@chillt.de> [1] Revision Changes Path 1.4 +18 -0 ports/audio/amarok/files/patch-amarok_src_mediadevice_generic_genericmediadevice.cpp (new) 1.28 +4 -0 ports/audio/amarok/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks !