Bug 109297 - [PATCH] Update port: dns/updatedd version 2.6
Summary: [PATCH] Update port: dns/updatedd version 2.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Gabor Kovesdan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-18 21:20 UTC by David Sze
Modified: 2007-02-28 20:10 UTC (History)
0 users

See Also:


Attachments
file.shar (5.91 KB, text/plain)
2007-02-18 21:20 UTC, David Sze
no flags Details
updatedd-2.6.shar (6.87 KB, application/x-shar)
2007-02-19 21:17 UTC, David Sze
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Sze 2007-02-18 21:20:11 UTC
The attached patch updates the dns/updatedd port to version 2.6.

I'm not the maintainer of the port, but it looks like the original maintainer has lost interest since there have been multiple releases since original port creation 3 years ago.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-18 21:20:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Jason DiCioccio 2007-02-19 17:16:55 UTC
I've actually made a patch for this update, however there are still issues
that either I or the updatedd author need to work out, which is why I
haven't requested it be committed.  This patch seems to suffer the same
issue.  Just try using the ods plugin, it segfaults every time I attempt
it, and that was the first one I attempted.  If all the other plugins are
working ok, then I'll pass this through, but I didn't want it to be too
broken.

Regards,
-JD-


> Maintainer of dns/updatedd,
>
> Please note that PR ports/109297 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/109297
>
> --
> Edwin Groothuis
> edwin@FreeBSD.org
>
>
Comment 3 David Sze 2007-02-19 21:17:44 UTC
Try the attached update.  It appears the segfault was due to the
author relying on semantics of vsprintf that are only true on
Linux (passing NULL for the first parameter to get the formatted
string length).

The port now has a patch to use the BSD-specific vasprintf instead.

It looks like only the ods and tzo plugins were affected.  I don't
have accounts with either of those services so I can't test it
thoroughly.  I only use dyndns and that works fine.
Comment 4 Jason DiCioccio 2007-02-19 21:28:20 UTC
David,

> Try the attached update.  It appears the segfault was due to the
> author relying on semantics of vsprintf that are only true on
> Linux (passing NULL for the first parameter to get the formatted
> string length).
>
> The port now has a patch to use the BSD-specific vasprintf instead.

I approve the update.

Thank you!
Jason DiCioccio
Comment 5 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-20 17:50:53 UTC
State Changed
From-To: feedback->open

Maintaner approved. 


Comment 6 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-20 17:50:53 UTC
Responsible Changed
From-To: freebsd-ports-bugs->gabor

Take.
Comment 7 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-25 14:16:04 UTC
State Changed
From-To: open->feedback

Hello David, 

unfortunately the shell archive has been corrupted by your mail client, I can 
not use it. Could you please resend this change to me in private mail? 
And please send changes in unified diffs to make our work easier. 

Thanks in advance, 
Gabor
Comment 8 dfilter service freebsd_committer freebsd_triage 2007-02-28 20:05:26 UTC
gabor       2007-02-28 20:05:21 UTC

  FreeBSD ports repository

  Modified files:
    dns/updatedd         Makefile distinfo pkg-descr pkg-plist 
  Added files:
    dns/updatedd/files   extrapatch-disable-portdocs 
                         patch-include-dprintf.h 
                         patch-updatedd-wrapper-Makefile.in 
  Removed files:
    dns/updatedd/files   patch-updatedd.c 
  Log:
  - Update to 2.6
  - Update pkg-descr
  
  PR:             ports/109297
  Submitted by:   David Sze <dsze@alumni.uwaterloo.ca>
  Approved by:    Jason DiCioccio <jd@ods.org> (maintainer),
                  erwin (mentor, implicit)
  
  Revision  Changes    Path
  1.5       +14 -20    ports/dns/updatedd/Makefile
  1.4       +3 -3      ports/dns/updatedd/distinfo
  1.1       +11 -0     ports/dns/updatedd/files/extrapatch-disable-portdocs (new)
  1.1       +18 -0     ports/dns/updatedd/files/patch-include-dprintf.h (new)
  1.1       +12 -0     ports/dns/updatedd/files/patch-updatedd-wrapper-Makefile.in (new)
  1.2       +0 -15     ports/dns/updatedd/files/patch-updatedd.c (dead)
  1.3       +18 -10    ports/dns/updatedd/pkg-descr
  1.2       +55 -14    ports/dns/updatedd/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Gabor Kovesdan freebsd_committer freebsd_triage 2007-02-28 20:05:55 UTC
State Changed
From-To: feedback->closed

Committed, thanks!