Bug 109596 - patch for benchmarks/unixbench: execl benchmark fails on 64-bit machines
Summary: patch for benchmarks/unixbench: execl benchmark fails on 64-bit machines
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Eßer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-27 11:30 UTC by Ivan Voras
Modified: 2007-03-23 08:30 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Voras 2007-02-27 11:30:10 UTC
	
    execl benchmark is not 64-bit ready, and crashes when 0 is passed
    to execl(2) instead of NULL.

Fix: 

Since unixbench is unmaintained, I propose this patch be added
as a local FreeBSD ports patch.--LtKMN5XgQz8EQYR77CggR1kAe3S787F09uX5e9GcM7icvlVh
Content-Type: text/plain; name="file.shar"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.shar"

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#       unixbench_execl.patch
#
echo x - unixbench_execl.patch
sed 's/^X//' >unixbench_execl.patch << 'END-of-unixbench_execl.patch'
X--- unixbench-4.1.0/src/execl.c        Wed Jul 28 21:46:58 1999
X+++ unixbench-4.1.0-new/src/execl.c    Tue Feb 27 10:06:48 2007
X@@ -88,7 +88,7 @@
X               fprintf(stderr, "%lu loops\n", iter);
X               exit(0);
X               }
X-      execl(fullpath, fullpath, "0", dur_str, count_str, start_str, 0);
X+      execl(fullpath, fullpath, "0", dur_str, count_str, start_str, NULL);
X       printf("Exec failed at iteration %lu\n", iter);
X       perror("Reason");
X       exit(1);
END-of-unixbench_execl.patch
exit
How-To-Repeat: 	
    Run execl benchmark on amd64, observe the error message.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-27 11:30:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->se

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-03-23 08:22:20 UTC
miwi        2007-03-23 08:22:13 UTC

  FreeBSD ports repository

  Modified files:
    benchmarks/unixbench Makefile 
  Added files:
    benchmarks/unixbench/files patch-execl.c 
  Log:
  - Fix build crash on amd64
  
  PR:             109596
  Submitted by:   Ivan Voras <ivoras@gmail.com>
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.22      +1 -0      ports/benchmarks/unixbench/Makefile
  1.1       +11 -0     ports/benchmarks/unixbench/files/patch-execl.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2007-03-23 08:22:28 UTC
State Changed
From-To: open->closed

Committed. Thanks!