Bug 109639 - graphics/gsculpt: doesn't respect CXX/CXXFLAGS
Summary: graphics/gsculpt: doesn't respect CXX/CXXFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-27 19:30 UTC by Dmitry Marakasov
Modified: 2007-03-02 17:30 UTC (History)
0 users

See Also:


Attachments
patch-gsculpt (98.45 KB, text/plain; charset=us-ascii)
2007-03-01 15:59 UTC, Martin Tournoij
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2007-02-27 19:30:06 UTC
% cd /usr/ports/graphics/gsculpt && make
...
===>  Building for gsculpt-0.99.38.2
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
g++ -o cpp/CompGeometry/PolyTesselate.os -c -Wall -Werror -ffast-math -g -DGS_DllExport= -DGSCULPT_PLATFORM_POSIX -DGSCULPT_FPU_X86 -fPIC -Icpp -I/usr/local/include/python2.4 -I/usr/local/include -I/usr/X11R6/include cpp/CompGeometry/PolyTesselate.cpp

while system compiler setting (${CXX} == c++) and flags (${CXXFLAGS} == -O2 -pipe -march=...) should be respected

Fix: 

Not a fix, but just a hint: you may modify software's SConstruct like that:

env = Environment(**ARGUMENTS)

thus, all systemwide settings (CC/CXX/CFLAGS/CXXFLAGS and more), passed to scons automatically by ports collection (see ports/Mk/bsd.scons.mk) via SCONS_ENV will be understood by scons and imported into it's build environment.
How-To-Repeat: cd /usr/ports/graphics/gsculpt && CXX=yourcompiler CXXFLAGS=yourflags make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-02-27 19:30:20 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Martin Tournoij 2007-03-01 15:59:24 UTC
This patch will:

- Update gSculpt to 0.00.39

- gSculpt now respects CXX and CXXFLAGS, note that gSculot doesn't
	compile with any -O flags, they are removed automatically by the
	SConstruct

- Use PYTHONPREFIX_SITELIBDIR and TARGETDIR instead of
	PYTHON_SITELIBDIR and PREFIX when installing files.


Regards,
Martin
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2007-03-01 16:48:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

Eat.
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-03-02 17:27:03 UTC
rafan       2007-03-02 17:26:49 UTC

  FreeBSD ports repository

  Modified files:
    graphics/gsculpt     Makefile distinfo pkg-plist 
    graphics/gsculpt/files SConstruct-install.in 
  Added files:
    graphics/gsculpt/files patch-SConstruct 
  Log:
  - Update to 0.99.39
  - Respect CXX and CXXFLAGS
    - gSculot doesn't compile with any -O flags, they are removed
      automatically by SConstruct
  - Use PYTHONPREFIX_SITELIBDIR when installing files
  
  PR:             ports/109639
  Submitted by:   Martin Tournoij <carpetsmoker at xs4all.nl> (maintainer)
  
  Revision  Changes    Path
  1.19      +9 -9      ports/graphics/gsculpt/Makefile
  1.6       +3 -3      ports/graphics/gsculpt/distinfo
  1.2       +370 -369  ports/graphics/gsculpt/files/SConstruct-install.in
  1.1       +45 -0     ports/graphics/gsculpt/files/patch-SConstruct (new)
  1.4       +1 -0      ports/graphics/gsculpt/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Rong-En Fan freebsd_committer freebsd_triage 2007-03-02 17:27:04 UTC
State Changed
From-To: feedback->closed

Committed without TARGETDIR.