Bug 110036 - [PATCH] shells/scponly add OPTIONS
Summary: [PATCH] shells/scponly add OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-07 16:20 UTC by Martin Matuska
Modified: 2007-08-13 11:59 UTC (History)
0 users

See Also:


Attachments
file.diff (934 bytes, patch)
2007-03-07 16:20 UTC, Martin Matuska
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matuska 2007-03-07 16:20:03 UTC
Adds OPTIONS for the various knobs in scponly
SCPONLY_WILDCARDS uses a WITHOUT_ knob so it is "on" by default.

Portlint and tinderbox do not complain.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-03-07 16:20:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rushani

Over to maintainer
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2007-03-11 06:14:11 UTC
Responsible Changed
From-To: rushani->freebsd-ports-bugs

Although the maintainer is a committer, maintainer does not have ports 
commit privileges. 

From his email to freebsd-ports-bugs: 

Date: Sun, 11 Mar 2007 13:49:02 +0900 (JST) 
Comment 3 Norikatsu Shigemura freebsd_committer freebsd_triage 2007-03-11 06:42:11 UTC
Responsible Changed
From-To: freebsd-ports-bugs->nork

I'll handle this.
Comment 4 Martin Matuska freebsd_committer freebsd_triage 2007-07-27 00:53:10 UTC
Responsible Changed
From-To: nork->mm

Maintainer approved and responsible (nork) did nothing for over 4  
months. Submitter is now commiter so submitter takes over.
Comment 5 Martin Matuska freebsd_committer freebsd_triage 2007-07-27 01:13:02 UTC
Revised patch, maintainer please approve.

Index: ports/shells/scponly/Makefile
===================================================================
RCS file: /home/pcvs/ports/shells/scponly/Makefile,v
retrieving revision 1.25
diff -u -r1.25 Makefile
--- ports/shells/scponly/Makefile    6 Aug 2006 17:38:15 -0000    1.25
+++ ports/shells/scponly/Makefile    27 Jul 2007 00:04:18 -0000
@@ -71,7 +71,7 @@
 
 PORTNAME=    scponly
 PORTVERSION=    4.6
-PORTREVISION=    1
+PORTREVISION=    2
 CATEGORIES=    shells
 MASTER_SITES=    http://www.sublimation.org/scponly/ \
         ${MASTER_SITE_SOURCEFORGE}
@@ -84,10 +84,19 @@
 MAN8=        scponly.8
 
 GNU_CONFIGURE=    yes
-PLIST_SUB+=    SCPONLY_CHROOT="@comment "
 
 PATCH_STRIP=    -p1
 
+OPTIONS=    SCPONLY_WILDCARDS "wildcards processing" on \
+        SCPONLY_GFTP "gftp compatibility" on \
+        SCPONLY_CHROOT "chroot functionality" off \
+        SCPONLY_RSYNC "rsync compatibility" off \
+        SCPONLY_SCP "vanilla scp compatibility" off \
+        SCPONLY_SFTP_LOGGING "sftp logging compatibility" off \
+        SCPONLY_SVNSERVE "subversion compatibility svn+ssh://" off \
+        SCPONLY_UNISON "unison compatibility" off \
+        SCPONLY_WINSCP "WinSCP compatibility" off
+
 .include <bsd.port.pre.mk>
 
 .if defined(SCPONLY_DEFAULT_CHDIR) && !empty(SCPONLY_DEFAULT_CHDIR)
@@ -103,8 +112,10 @@
 .endif
 
 .if defined(WITH_SCPONLY_CHROOT)
-PLIST_SUB=    SCPONLY_CHROOT=""
+PLIST_SUB+=    SCPONLY_CHROOT=""
 CONFIGURE_ARGS+=--enable-chrooted-binary
+.else
+PLIST_SUB+=    SCPONLY_CHROOT="@comment "
 .endif
 
 .if defined(WITH_SCPONLY_RSYNC)
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-08-13 11:34:26 UTC
mm          2007-08-13 10:34:18 UTC

  FreeBSD ports repository

  Modified files:
    shells/scponly       Makefile 
  Log:
  - Add OPTIONS for included knobs
  
  PR:             ports/110036
  Approved by:    maintainer (timeout), garga (mentor, implicit)
  
  Revision  Changes    Path
  1.26      +15 -3     ports/shells/scponly/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Martin Matuska freebsd_committer freebsd_triage 2007-08-13 11:58:28 UTC
State Changed
From-To: open->closed

Commited with minor changes, thanks!