Bug 110208 - fix WITH_ and WITHOUT_ options usage in multimedia/audacious-plugins
Summary: fix WITH_ and WITHOUT_ options usage in multimedia/audacious-plugins
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Oliver Lehmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-12 06:50 UTC by Eygene Ryabinkin
Modified: 2007-03-12 20:50 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (2.83 KB, patch)
2007-03-12 06:50 UTC, Eygene Ryabinkin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin 2007-03-12 06:50:03 UTC 
The Makefile of ports/multimedia/audacious-plugins uses WITHOUT_<OPTION>
clause when the respective OPTION is set to 'Off' in the OPTIONS variable.
This breaks the builds with BATCH=yes: the respective options are effectively
stays 'Off' even if WITH_<OPTION> is defined.

For the longer explanation on WITH_, WITHOUT_ and BATCH see
Porter's Handbook, section 5.11.2 or drop me a letter.

Fix: The patch made against Makefile 1.31 is below. I successfully applied
it to the latest Makefile (1,34), but not tested the building yet. For
1.31 (and the port version 1.3.0) it works OK. I see no changes in the
OPTIONS defaults, so it should work with 1.34 too.
How-To-Repeat: Do 'make -DBATCH -DWITH_VORBIS=yes configure' in the port's directory
and see that Ogg Vorbis support is off.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-03-12 06:50:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->oliver

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-03-12 20:48:02 UTC 
oliver      2007-03-12 20:47:57 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/audacious-plugins Makefile 
  Log:
  fix option handling
  
  PR:             110208
  Submitted by:   Eygene Ryabinkin <rea-fbsd@codelabs.ru>
  
  Revision  Changes    Path
  1.35      +12 -12    ports/multimedia/audacious-plugins/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Oliver Lehmann freebsd_committer freebsd_triage 2007-03-12 20:48:16 UTC 
State Changed
From-To: open->closed

committed, thanks