Bug 110687 - misc/amanda-client AMANDA_PORTRANGE knob broken
Summary: misc/amanda-client AMANDA_PORTRANGE knob broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 00:20 UTC by rand
Modified: 2007-03-25 13:00 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rand 2007-03-23 00:20:00 UTC
	The configuration knob AMANDA_PORTRANGE nolonger works for the
	misc/amanda-client port. This happened between Amanda 2.5.0 and
	2.5.1. Rev 1.327 of Amanda's configure.in silently dropped
	support for --with-portrange in preference to the (better named)
	--with-tcpportrange.

Fix: The shortest patch is trivial:




There is a reasonable argument that the AMANDA_PORTRANGE knob
	should be renamed. I'll leave the decision to the maintainer
	if this should be changed to AMANDA_TCPPORTRANGE instead. If
	so, again the patch is trivial.--QDOGWmXBw9xii2kx1YDysRBwMvviiNGCGx1tfOOlViRK5x2e
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- Makefile-orig	Thu Mar 22 18:40:50 2007
+++ Makefile	Thu Mar 22 18:41:01 2007
@@ -57,7 +57,7 @@
 .endif
 
 .if defined (AMANDA_PORTRANGE)
-CONFIGURE_ARGS+=	--with-portrange=${AMANDA_PORTRANGE}
+CONFIGURE_ARGS+=	--with-tcpportrange=${AMANDA_PORTRANGE}
 .endif
 
 .if !defined(WITHOUT_GNUTAR)
How-To-Repeat: 	Attempt to use amanda-client 2.5.1 or later along with the
	AMANDA_PORTRANGE knob set. The configure script will silently
	ignore the --with-portrange option.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-03-23 00:20:08 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kuriyama

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-03-25 12:53:36 UTC
kuriyama    2007-03-25 11:53:31 UTC

  FreeBSD ports repository

  Modified files:
    misc/amanda-server   Makefile 
  Log:
  - Fix AMANDA_PORTRANGE knob, and rename it to AMANDA_TCPPORTRANGE.
  
  PR:             ports/110687
  Submitted by:   "Douglas K. Rand" <rand@meridian-enviro.com>
  
  Revision  Changes    Path
  1.97      +8 -4      ports/misc/amanda-server/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Jun Kuriyama freebsd_committer freebsd_triage 2007-03-25 12:53:43 UTC
State Changed
From-To: open->closed

Committed, thanks!