- Fix a breakage caused by revision v 1.91 of ports/lang/tcl84/Makefile - Switch to USE_TCL - s/INSTALLS_SHLIB/USE_LDCONFIG/ - Support tcl84-thread - Fix tclsh detection in configure - Move the test target to regression-test - Pet portlint. Fix: Please apply the folowing patch: How-To-Repeat: See errors logs on pointyhat: <http://portsmon.droso.net/portoverview.py?category=lang&portname=tclX>
Responsible Changed From-To: freebsd-ports-bugs->thierry Submitter has GNATS access
State Changed From-To: open->feedback Awaiting maintainers feedback
Responsible Changed From-To: thierry->mi Assign to maintainer.
On Sun 25 mar 07 at 17:25:59 +0200, Thierry Thomas <thierry@FreeBSD.org> wrote: > > - s/INSTALLS_SHLIB/USE_LDCONFIG/ Actually neither INSTALLS_SHLIB nor USE_LDCONFIG are useful for this port. Regards, -- Th. Thomas.
On Monday 26 March 2007 02:59, Thierry Thomas wrote: = > http://pointyhat.freebsd.org/errorlogs/amd64-errorlogs/e.5.2007032316/tclX-8.4.log = > = > shows some failures in the nice.test, which are fatal in the current = > version of the port. = = The failure in the tests is not fatal on my machine. *That* is, likely, because you've already moved the test target into regression-test, whose failure is not fatal :-) = > = The failure is when the port rebuilds man pages, and it is addressed by = > = patch-af. = > = > Khmm, this I was not aware off. Nor do I see it in my builds. Your patch = > may, indeed, fix that, but I'd like to figure out, what's wrong with the = > nice command now. = > = > It was all working fine for months (years?) until something changed in the = > jail-implementation... = But this failure is fatal for me, and I'm the culprit... Since = revision v 1.91 of ports/lang/tcl84/Makefile, the macros included in = the man pages of TCL exist, and was not handled correctly. I see... If you leave the test target alone (keeping it part of ALL_TARGET and without introducing the regression-test target for now), you can commit your changes yourself. Thanks a lot! -mi
thierry 2007-03-26 17:11:37 UTC FreeBSD ports repository Modified files: lang/tclX Makefile lang/tclX/files patch-af Added files: lang/tclX/files patch-configure Log: - Fix a breakage caused by revision v 1.91 of ports/lang/tcl84/Makefile - Switch to USE_TCL - s/INSTALLS_SHLIB/USE_LDCONFIG/ - Support tcl84-thread - Fix tclsh detection in configure - Pet portlint. Note: this port is still broken, because a test is failing, and tests are part of the all target. PR: ports/110805 Submitted by: /me Approved by: mi (excepted the move of tests to a regression-test target) Revision Changes Path 1.53 +21 -14 ports/lang/tclX/Makefile 1.4 +18 -7 ports/lang/tclX/files/patch-af 1.1 +11 -0 ports/lang/tclX/files/patch-configure (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->patched Patch committed, excepted the move of tests to the separate target regression-test. Also, since the port is still broken, don't bump PORTREVISION.
State Changed From-To: patched->closed Patched a while ago, seems fine.