Among many other things, syslog-ng changed the default configuration file path determination method between 2.0.0 and 2.0.3. This was missed by the port maintainer (an easy mistake if you set $syslog_ng_flags="-f /alt/file.conf" seklecki@ravage:/tmp$ diff -u syslog-ng-2.0.0/syslog-ng.spec.bb \ syslog-ng-2.0.2/syslog-ng.spec.bb | grep -i conf -./configure --prefix=/ --mandir=/usr/share/man --infodir=/usr/share/info \ - --sysconfdir=/etc +./configure --prefix=%{prefix} --mandir=%{_mandir} --infodir=%{prefix}/share/info \ + --sysconfdir=/etc/syslog-ng ------------------------------- Fix: Regardless of when/why this changed and who is responsible, here are the corrective actions that need to be taken to resolve the problem: -) pkg-plist needs to reflect %%PREFIX%%/etc/syslog-ng.conf instead of etc/syslog-ng/syslog-ng.conf -) pkg-message needs to mention that configuration file path has changed -) ${required_files}= in ports/sysutils/syslog-ng2/files/syslog-ng.sh.in needs to reflect %%PREFIX%%/etc/syslog-ng.conf instead of %%PREFIX%%/etc/syslog-ng/syslog-ng.conf How-To-Repeat: Portupgrade to 2.0.2
State Changed From-To: open->feedback Awaiting maintainers feedback
Got it; i'll produce a standard patch ASAP
>Submitter-Id: current-users >Originator: Ivan Lago >Organization: European Institute of Oncology >Confidential: no >Synopsis: re:ports/111462: syslog-ng2 default configuration file path >Severity: serious >Priority: medium >Category: ports >Class: maintainer-update >Release: FreeBSD 6.2-RELEASE-p3 amd64 >Environment: System: FreeBSD sodio.ifom-ieo-campus.it 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3 #5: Fri Mar 16 15:21:33 CET 2007 root@sodio.ifom-ieo-campus.it:/usr/obj/usr/src/sys/SODIO amd64 >Description: Among many other things, syslog-ng changed the default configuration file path determination method between 2.0.0 and 2.0.3. This was missed by the port maintainer (an easy mistake if you set $syslog_ng_flags="-f /alt/file.conf" seklecki@ravage:/tmp$ diff -u syslog-ng-2.0.0/syslog-ng.spec.bb \ syslog-ng-2.0.2/syslog-ng.spec.bb | grep -i conf -./configure --prefix=/ --mandir=/usr/share/man --infodir=/usr/share/info \ - --sysconfdir=/etc +./configure --prefix=%{prefix} --mandir=%{_mandir} --infodir=%{prefix}/share/info \ + --sysconfdir=/etc/syslog-ng >How-To-Repeat: portupgrade to 2.0.2 >Fix: --- syslog-ng2.patch begins here --- diff -ruN /usr/ports/sysutils/syslog-ng2/files/pkg-message.in syslog-ng2/files/pkg-message.in --- /usr/ports/sysutils/syslog-ng2/files/pkg-message.in Thu Mar 22 17:30:16 2007 +++ syslog-ng2/files/pkg-message.in Mon Apr 16 16:46:51 2007 @@ -2,8 +2,12 @@ syslog-ng is now installed! To replace FreeBSD's standard syslogd (/usr/sbin/syslogd), complete these steps: -1. Create a configuration file named %%PREFIX%%/etc/syslog-ng/syslog-ng.conf - (a sample named syslog-ng.conf.sample has been included) +1. Create a configuration file named %%PREFIX%%/etc/syslog-ng.conf + (a sample named syslog-ng.conf.sample has been included in + %%PREFIX%%/etc/syslog-ng). Note that this is a change in 2.0.2 + version, previous ones put the config file in + %%PREFIX%%/etc/syslog-ng/syslog-ng.conf, so if this is an update + move that file in the right place 2. Configure syslog-ng to start automatically by adding the following to /etc/rc.conf: diff -ruN /usr/ports/sysutils/syslog-ng2/files/syslog-ng.sh.in syslog-ng2/files/syslog-ng.sh.in --- /usr/ports/sysutils/syslog-ng2/files/syslog-ng.sh.in Thu Mar 22 17:30:16 2007 +++ syslog-ng2/files/syslog-ng.sh.in Mon Apr 16 16:16:11 2007 @@ -24,7 +24,7 @@ rcvar=`set_rcvar` command=%%PREFIX%%/sbin/syslog-ng -required_files=%%PREFIX%%/etc/syslog-ng/syslog-ng.conf +required_files=%%PREFIX%%/etc/syslog-ng.conf extra_commands=reload if checkyesno syslog_ng_purgeklog; then --- syslog-ng2.patch ends here ---
The patch looks great; has my thumbs up for a commit. ~BAS On Wed, 2007-04-11 at 09:41 +0200, Ivan Lago wrote: > Got it; i'll produce a standard patch ASAP > > > > > > -- Brian A. Seklecki <bseklecki@collaborativefusion.com> Collaborative Fusion, Inc. IMPORTANT: This message contains confidential information and is intended only for the individual named. If the reader of this message is not an intended recipient (or the individual responsible for the delivery of this message to an intended recipient), please be advised that any re-use, dissemination, distribution or copying of this message is prohibited. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system.
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->tmclaugh Grab.
Responsible Changed From-To: tmclaugh->linimon Over to linimon per request
State Changed From-To: open->closed Committed the maintainer's patch.
pav 2007-07-28 22:28:08 UTC FreeBSD ports repository Modified files: sysutils/syslog-ng2 Makefile sysutils/syslog-ng2/files pkg-message.in syslog-ng.sh.in Log: - Correct the location of a configuration file PR: ports/111462 Reported by: Brian A. Seklecki <bseklecki@collaborativefusion.com> Submitted by: Ivan Lago <ivan.lago@ifom-ieo-campus.it> (maintainer) Revision Changes Path 1.6 +1 -0 ports/sysutils/syslog-ng2/Makefile 1.2 +6 -2 ports/sysutils/syslog-ng2/files/pkg-message.in 1.4 +2 -2 ports/sysutils/syslog-ng2/files/syslog-ng.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"