I meant to send this PR's (and the following) before (just after the repo-copy request), but had some things this week.. :-S FYI we were doing some stuff in http://code.google.com/p/asterisk-bsd/ This patch merges asterisk14 of the freebsd ports with the one of the project. About the files/* freebsd-port parches, i really dont understand 100% whats going on, but without them (i.e. *.c and Makefiles) asterisk apear to work just fine. Anyway, Ive leave them there except for patch-Makefile wich i dont know whats fixing... and tinderbox could not replace $(MKDIR) $(BSD_INSTALL_SCRIPT). Changes: - Remove mpg123 depends (asterisk has its own mp3 lib) - Shrink MAKE_ENV VARs (does it really need it?...) - Remove CONFIGURE_ENV (does it reallt need it?...) - Delete CONFIGURE_ARGS (Asterisk autotdetect them) - Add more OPTION; remove explicit --with/--without; check for WITH instead of WITHOUT - Update zaptel.h reference thanks!
Responsible Changed From-To: freebsd-ports-bugs->sobomax Over to maintainer
State Changed From-To: open->closed Useful part of the PR commited (Jabber/Gtalk support), thanks! As for the rest of proposed changes please see the quick summary below: 1. mpg123 binary is still referenced by several .c modules, so that I assume it's still being used somehow. 2. All MAKE_ENV entries are referenced in the Makefiles. I don't have a time to run a full test, so that it's safe to leave them in. 3. CONFIGURE_ENV is really necessary. 4. CONFIGURE_ARGS is really necessary too. Auto-detection is bad since it will cause incomplete packing list to be generated when some disabled components are auto-detected. 5. See (4) above regarding with/without. 6. There is no difference checking for WITH or WITHOUT. The change is rejected hence as superfluous. The same goes for %%DATADIR%%. Personally, I don't like %%DATADIR%% since it makes updating packing list more difficult. 7. I see no point is SAMPLE_CONFIG option. The change is rejected therefore. In any case, thank you for submission.
sobomax 2007-04-16 08:40:15 UTC FreeBSD ports repository Modified files: net/asterisk Makefile pkg-plist net/asterisk/files patch-Makefile Log: Add Jabber and Gtalk support. PR: 111553 Submitted by: pneumann at gmail.com Revision Changes Path 1.68 +11 -1 ports/net/asterisk/Makefile 1.19 +9 -0 ports/net/asterisk/files/patch-Makefile 1.25 +2 -0 ports/net/asterisk/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"