Bug 111801 - Switch audio/juk to gstreamer-0.10
Summary: Switch audio/juk to gstreamer-0.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-18 01:40 UTC by Dima Panov
Modified: 2007-04-23 20:18 UTC (History)
0 users

See Also:


Attachments
file.diff (775 bytes, patch)
2007-04-18 01:40 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov 2007-04-18 01:40:01 UTC
	
    audio/juk now have full support for gstreamer-0.10
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-04-18 01:40:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer
Comment 2 Dima Panov 2007-04-18 02:04:20 UTC
On 18 April 2007 11:31, Dima Panov wrote:
> >Number:         111801
> >Category:       ports
> >Synopsis:       Switch audio/juk to gstreamer-0.10


Sorry, forgot to use new style definition for gstreamer

Index: audio/juk/Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/juk/Makefile,v
retrieving revision 1.29
diff -u -r1.29 Makefile
--- audio/juk/Makefile	17 Apr 2007 14:18:12 -0000	1.29
+++ audio/juk/Makefile	18 Apr 2007 01:03:29 -0000
@@ -41,17 +41,11 @@
 
 .include <bsd.port.pre.mk>
 
-.if exists(${X11BASE}/lib/libgstplay-0.8.so)
-.	if !defined(WITH_GSTREAMER)
+.if exists(${X11BASE}/lib/libgstreamer-0.10.so)
 GSTREAMER_OVERRIDE=yes
-WITH_GSTREAMER=	yes
-.	endif
+USE_GSTREAMER=	yes
 .endif
 
-.if defined(WITH_GSTREAMER)
-LIB_DEPENDS+=	gstreamer:${PORTSDIR}/multimedia/gstreamer80 \
-		gstplay:${PORTSDIR}/multimedia/gstreamer-plugins80
-.endif
 
 pre-everything::
 .if defined(GSTREAMER_OVERRIDE)


-- 
äÍÉÔÒÉÊ á. ðÁÎÏ×

áËÁÄÅÍÉÑ üËÏÎÏÍÉËÉ É ðÒÁ×Á
èÁÂÁÒÏ×ÓË, òÏÓÓÉÑ
Comment 3 Michael Johnson 2007-04-18 12:28:42 UTC
T24gNC8xNy8wNywgRGltYSBQYW5vdiA8Zmx1ZmZ5QGFlbC5ydT4gd3JvdGU6Cj4gT24gMTggQXBy
aWwgMjAwNyAxMTozMSwgRGltYSBQYW5vdiB3cm90ZToKPiA+ID5OdW1iZXI6ICAgICAgICAgMTEx
ODAxCj4gPiA+Q2F0ZWdvcnk6ICAgICAgIHBvcnRzCj4gPiA+U3lub3BzaXM6ICAgICAgIFN3aXRj
aCBhdWRpby9qdWsgdG8gZ3N0cmVhbWVyLTAuMTAKPgo+Cj4gU29ycnksIGZvcmdvdCB0byB1c2Ug
bmV3IHN0eWxlIGRlZmluaXRpb24gZm9yIGdzdHJlYW1lcgo+Cj4gSW5kZXg6IGF1ZGlvL2p1ay9N
YWtlZmlsZQo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KPiBSQ1MgZmlsZTogL2hvbWUvbmN2cy9wb3J0cy9hdWRpby9q
dWsvTWFrZWZpbGUsdgo+IHJldHJpZXZpbmcgcmV2aXNpb24gMS4yOQo+IGRpZmYgLXUgLXIxLjI5
IE1ha2VmaWxlCj4gLS0tIGF1ZGlvL2p1ay9NYWtlZmlsZSAgMTcgQXByIDIwMDcgMTQ6MTg6MTIg
LTAwMDAgICAgICAxLjI5Cj4gKysrIGF1ZGlvL2p1ay9NYWtlZmlsZSAgMTggQXByIDIwMDcgMDE6
MDM6MjkgLTAwMDAKPiBAQCAtNDEsMTcgKzQxLDExIEBACj4KPiAgLmluY2x1ZGUgPGJzZC5wb3J0
LnByZS5taz4KPgo+IC0uaWYgZXhpc3RzKCR7WDExQkFTRX0vbGliL2xpYmdzdHBsYXktMC44LnNv
KQo+IC0uICAgICAgaWYgIWRlZmluZWQoV0lUSF9HU1RSRUFNRVIpCj4gKy5pZiBleGlzdHMoJHtY
MTFCQVNFfS9saWIvbGliZ3N0cmVhbWVyLTAuMTAuc28pCgpHc3RyZWFtZXIgbGl2ZXMgaW4gTE9D
QUxCQVNFIG5vdy4KCj4gIEdTVFJFQU1FUl9PVkVSUklERT15ZXMKPiAtV0lUSF9HU1RSRUFNRVI9
ICAgICAgICB5ZXMKPiAtLiAgICAgIGVuZGlmCj4gK1VTRV9HU1RSRUFNRVI9IHllcwoKYWxzbywg
V0FOVF9HU1RSRUFNRVIgbmVlZHMgdG8gYmUgZGVmaW5lZCBiZWZvcmUgYnNkLnBvcnQucHJlLm1r
IGlmCml0IGlzIG5vdCBhbHJlYWR5IGRlZmluZWQuCgo+ICAuZW5kaWYKPgo+IC0uaWYgZGVmaW5l
ZChXSVRIX0dTVFJFQU1FUikKPiAtTElCX0RFUEVORFMrPSAgZ3N0cmVhbWVyOiR7UE9SVFNESVJ9
L211bHRpbWVkaWEvZ3N0cmVhbWVyODAgXAo+IC0gICAgICAgICAgICAgICBnc3RwbGF5OiR7UE9S
VFNESVJ9L211bHRpbWVkaWEvZ3N0cmVhbWVyLXBsdWdpbnM4MAo+IC0uZW5kaWYKPgo+ICBwcmUt
ZXZlcnl0aGluZzo6Cj4gIC5pZiBkZWZpbmVkKEdTVFJFQU1FUl9PVkVSUklERSkKPgo+Cj4gLS0K
PiDkzcnU0snKIOEuIPDBzs/XCj4KPiDhy8HExc3J0SD8y8/Oz83Jy8kgySDw0sHXwQo+IOjBwsHS
z9fTyywg8s/T08nRCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KPiBmcmVlYnNkLXBvcnRzLWJ1Z3NAZnJlZWJzZC5vcmcgbWFpbGluZyBsaXN0Cj4gaHR0
cDovL2xpc3RzLmZyZWVic2Qub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWJzZC1wb3J0cy1idWdz
Cj4gVG8gdW5zdWJzY3JpYmUsIHNlbmQgYW55IG1haWwgdG8gImZyZWVic2QtcG9ydHMtYnVncy11
bnN1YnNjcmliZUBmcmVlYnNkLm9yZyIKPgo=
Comment 4 Michael Nottebrock freebsd_committer freebsd_triage 2007-04-18 16:58:37 UTC
Just in case anybody else is confused by the block of uuencoded text ahze@ 
sent, he meant to say:

> --- audio/juk/Makefile  17 Apr 2007 14:18:12 -0000      1.29
> +++ audio/juk/Makefile  18 Apr 2007 01:03:29 -0000
> @@ -41,17 +41,11 @@
>
>  .include <bsd.port.pre.mk>
>
> -.if exists(${X11BASE}/lib/libgstplay-0.8.so)
> -.      if !defined(WITH_GSTREAMER)
> +.if exists(${X11BASE}/lib/libgstreamer-0.10.so)

Gstreamer lives in LOCALBASE now.

>  GSTREAMER_OVERRIDE=yes
> -WITH_GSTREAMER=        yes
> -.      endif
> +USE_GSTREAMER= yes

also, WANT_GSTREAMER needs to be defined before bsd.port.pre.mk if
it is not already defined.
Comment 5 Dima Panov 2007-04-18 23:35:53 UTC
On 18 April 2007 22:28, Michael Johnson wrote:
> On 4/17/07, Dima Panov <fluffy@ael.ru> wrote:
> > On 18 April 2007 11:31, Dima Panov wrote:
> > > >Number:         111801
> > > >Category:       ports
> > > >Synopsis:       Switch audio/juk to gstreamer-0.10
>
> Gstreamer lives in LOCALBASE now.
>
> also, WANT_GSTREAMER needs to be defined before bsd.port.pre.mk if
> it is not already defined.

OK, new revision is here:

Index: audio/juk/Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/juk/Makefile,v
retrieving revision 1.29
diff -u -r1.29 Makefile
--- audio/juk/Makefile	17 Apr 2007 14:18:12 -0000	1.29
+++ audio/juk/Makefile	18 Apr 2007 22:36:20 -0000
@@ -39,19 +39,15 @@
 CONFIGURE_ARGS+=CFLAGS=-I${LOCALBASE}/include/tunepimp-0.4 \
 		LDFLAGS=-L${LOCALBASE}/lib/tunepimp-0.4
 
+WANT_GSTREAMER=	yes
+
 .include <bsd.port.pre.mk>
 
-.if exists(${X11BASE}/lib/libgstplay-0.8.so)
-.	if !defined(WITH_GSTREAMER)
+.if  defined(WITH_GSTREAMER) || exists(${LOCALBASE}/lib/libgstreamer-0.10.so)
 GSTREAMER_OVERRIDE=yes
-WITH_GSTREAMER=	yes
-.	endif
+USE_GSTREAMER=	yes
 .endif
 
-.if defined(WITH_GSTREAMER)
-LIB_DEPENDS+=	gstreamer:${PORTSDIR}/multimedia/gstreamer80 \
-		gstplay:${PORTSDIR}/multimedia/gstreamer-plugins80
-.endif
 
 pre-everything::
 .if defined(GSTREAMER_OVERRIDE)



-- 
äÍÉÔÒÉÊ á. ðÁÎÏ×

áËÁÄÅÍÉÑ üËÏÎÏÍÉËÉ É ðÒÁ×Á
èÁÂÁÒÏ×ÓË, òÏÓÓÉÑ
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-04-22 11:04:07 UTC
lofi        2007-04-22 10:04:00 UTC

  FreeBSD ports repository

  Modified files:
    audio/juk            Makefile 
  Log:
  Use gstreamer-0.10.
  
  PR:             ports/111801
  Submitted by:   Dima Panov <fluffy@ael.ru>
  
  Revision  Changes    Path
  1.30      +4 -8      ports/audio/juk/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Michael Nottebrock freebsd_committer freebsd_triage 2007-04-23 20:17:51 UTC
State Changed
From-To: open->closed

Committed, thanks!