Bug 111980 - multimedia/mplayer: compilation error
Summary: multimedia/mplayer: compilation error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-21 08:20 UTC by Robert Gogolok
Modified: 2007-07-09 15:00 UTC (History)
0 users

See Also:


Attachments
mplayer.diff (5.26 KB, patch)
2007-05-03 06:07 UTC, Thomas E. Zander
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Gogolok 2007-04-21 08:20:03 UTC
mplayer compilation fails with my tinderbox setup.

http://w5.cs.uni-sb.de/~gogo/log/mplayer-0.99.10_6.log

How-To-Repeat: Compile multimedia/mplayer with the following environment:
http://w5.cs.uni-sb.de/~gogo/log/mplayer-0.99.10_6.log.env
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-04-21 08:20:11 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Thomas E. Zander 2007-05-01 08:11:02 UTC
Hi,

could you please retry this build WITH_OPTIMIZED_CFLAGS?

Merci,
Riggs

-- 
- "[...] I talked to the computer at great length and
-- explained my view of the Universe to it" said Marvin.
--- And what happened?" pressed Ford.
---- "It committed suicide." said Marvin.
Comment 3 Thomas E. Zander 2007-05-02 03:02:52 UTC
Sorry, wrong. Could you please enable OCFLAGS via mplayer's options and
try again? THis should solve the problem.

Riggs

-- 
- "[...] I talked to the computer at great length and
-- explained my view of the Universe to it" said Marvin.
--- And what happened?" pressed Ford.
---- "It committed suicide." said Marvin.
Comment 4 Robert Gogolok 2007-05-02 14:31:35 UTC
On Wednesday 02 May 2007 04:02, Thomas E. Zander wrote:
> Sorry, wrong. Could you please enable OCFLAGS via mplayer's options and
> try again? THis should solve the problem.
OCFLAGS is enabled by default.

...
OPTIONS+= OCFLAGS "Use optimized compiler flags" on
...
.if !defined(WITHOUT_OCFLAGS)
CFLAGS+= -O3 -ffast-math -fomit-frame-pointer
.endif
...


Greetings,
Robert
Comment 5 Thomas E. Zander 2007-05-03 06:07:21 UTC
I believe I have found a solution that addresses several weaknesses:
o This PR, i.e. mplayer builds on i386 if WITH_DEBUG is defined
o ports/111088, i.e. this port does no longer depend on lame if
  PACKAGE_BUILDING is specified. In fact, all dependencies on
  restricted software is removed in this case, that would allow us to
  remove mplayer from LEGAL.
o Correct a dependency problem with the latest libcaca update

Robert, could you please test if this solves your problem? If possible,
I'd be interested in amd64 results as well (although I don't expect a
problem there).
Edwin, could you please briefly review if I am right with the
LEGAL/PACKAGE_BUILDING assumption and can we close 111088 as well if we
commit this diff?

Thanks,
Riggs

-- 
- "[...] I talked to the computer at great length and
-- explained my view of the Universe to it" said Marvin.
--- And what happened?" pressed Ford.
---- "It committed suicide." said Marvin.
Comment 6 Robert Gogolok 2007-05-03 09:58:07 UTC
> Robert, could you please test if this solves your problem? 
http://w5.cs.uni-sb.de/~gogo/log/mplayer-0.99.10_8.log

It seems to work!
Comment 7 dfilter service freebsd_committer freebsd_triage 2007-05-31 03:49:35 UTC
edwin       2007-05-31 02:49:29 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile 
  Log:
  multimedia/mplayer: compilation error
  
          mplayer compilation fails with my tinderbox setup.
  
  PR:             ports/111980
  Submitted by:   Robert Gogolok <gogo@cs.uni-sb.de>
  Reviewed by:    "Thomas E. Zander" <riggs@rrr.de>
  
  Revision  Changes    Path
  1.162     +19 -61    ports/multimedia/mplayer/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Edwin Groothuis freebsd_committer freebsd_triage 2007-05-31 03:49:56 UTC
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 9 Robert Gogolok 2007-07-09 13:50:33 UTC
The commit has been reverted so the bug report should be reopened.