Port fails to build when the readline 5.2 port is installed due to a conflict in include files. Following patch fixes that. Reported By: Paul Beard
Responsible Changed From-To: freebsd-ports-bugs->mm I'll take it.
Hello, I have found out that your port was not LOCALBASE compliant and the NO_INSTALL_MANPAGES knob was missing. With the CFLAGS you are adding, the replacement part in Makefile is not required anymore. I have added a NO_WERROR option to MAKE_ENV so that obexapp builds on FreeBSD 5.5. Updated patch is attached. If you agree, I will commit it. I have checked the updated patch on tinderbox. Logs: http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log
State Changed From-To: open->feedback Awaiting maintainers feedback
On Thu, May 03, 2007 at 02:42:08PM +0200, Martin Matuska wrote: > Hello, I have found out that your port was not LOCALBASE compliant and > the NO_INSTALL_MANPAGES knob was missing. > With the CFLAGS you are adding, the replacement part in Makefile is not > required anymore. I have added a NO_WERROR option to MAKE_ENV so that > obexapp builds on FreeBSD 5.5. > > Updated patch is attached. If you agree, I will commit it. > > I have checked the updated patch on tinderbox. > > Logs: > http://i386.vx.sk/logs/6.2-FreeBSD-i386/obexapp-1.4.6_1.log > http://i386.vx.sk/logs/5.5-FreeBSD-i386/obexapp-1.4.6_1.log > http://i386.vx.sk/logs/7-FreeBSD-i386/obexapp-1.4.6_1.log > http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/obexapp-1.4.6_1.log > http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/obexapp-1.4.6_1.log > http://amd64.vx.sk/logs/7-FreeBSD-amd64/obexapp-1.4.6_1.log > Very good work, thank you for your help! I looke at the patch and tried it and it's ok for me. The logs you provide are even better proof for that. Ok to commit. And thank you again! -- Guido Falsi <mad@madpilot.net>
State Changed From-To: feedback->open Maintainer approved
mm 2007-05-25 10:50:47 UTC FreeBSD ports repository Modified files: comms/obexapp Makefile comms/obexapp/files patch-Makefile Log: - counterpatch proposed by mm@ (maintainer approved) - fixed build on i386 if devel/readline installed - fixed build on FreeBSD 5.5 - added NO_INSTALL_MANPAGES knob PR: ports/112321 Approved by: garga (mentor) Revision Changes Path 1.15 +10 -6 ports/comms/obexapp/Makefile 1.9 +17 -5 ports/comms/obexapp/files/patch-Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Commited with modifications, thanks!