Bug 113367 - [PATCH]: Update/Cleanup net/silc-client
Summary: [PATCH]: Update/Cleanup net/silc-client
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Rong-En Fan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-05 15:30 UTC by Wesley Shields
Modified: 2007-06-21 20:30 UTC (History)
1 user (show)

See Also:


Attachments
file.diff (14.96 KB, patch)
2007-06-05 15:30 UTC, Wesley Shields
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wesley Shields 2007-06-05 15:30:07 UTC
Attached is a patch to net/silc-client which does quite a few things:

- Update to 1.1
- Remove USE_PERL5 (not necessary)
- Remove PKGDEINSTALL hacks (replace with Makefile and pkg-plist equivalents)
- Install the manpage
- Fix CFLAGS optimization (disabled by default still but without the
  post-patch hacking)
- Use REINPLACE_CMD instead of PERL
- Remove unnecessary OSVERSION check (4.x)
- Remove installation of unnecessary files (TODO...)
- Pass portlint checks (%%DATADIR%%, patch file names)

The patch removes: pkg-install, files/patch-doc-Makefile.in,
files/patch-irssi::src::core::network.c

The patch adds: files/patch-apps__irssi__Makefile.in,
files/patch-doc__Makefile.in

I've CC'ed the maintainer on this.  As I use this port daily and intend
on working on a patch to build silc-client as a plugin to irssi I am
willing to take over maintainer role for this port if desired.

How-To-Repeat: N/A
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-05 15:30:20 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Rong-En Fan freebsd_committer freebsd_triage 2007-06-21 11:40:51 UTC
Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.
Comment 3 Rong-En Fan freebsd_committer freebsd_triage 2007-06-21 20:29:51 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-06-21 20:29:55 UTC
rafan       2007-06-21 19:29:47 UTC

  FreeBSD ports repository

  Modified files:
    net/silc-client      Makefile distinfo pkg-plist 
  Added files:
    net/silc-client/files patch-apps__irssi__Makefile.in 
                          patch-doc__Makefile.in 
  Removed files:
    net/silc-client      pkg-install 
    net/silc-client/files patch-doc-Makefile.in 
                          patch-irssi::src::core::network.c 
  Log:
  - Update to 1.1
  - Install manual page
  
  Cleanups:
  
  - Remove USE_PERL5, use REINPLACE_CMD instead
  - Remove PKGDEINSTALL hacks. Replace the same functionality with
    Makefile and pkg-plist equivlents
  - Remove OPTIMIZED_CFLAGS knob, it is no use. -O2 is always on according
    to pointyhat build log
  - Remove unnecessary OSVERSION check for 4.x
  - Remove installation of unnecessary documents (TODO, CHANGES, etc.)
  - Use DOCSDIR, DATADIR macros
  
  PR:            ports/113367
  Submitted by:  Wesley Shields <wxs at atarininja.org>
  Approved by:   maintainer timeout (16 days)
  
  Revision  Changes    Path
  1.45      +14 -30    ports/net/silc-client/Makefile
  1.22      +3 -3      ports/net/silc-client/distinfo
  1.1       +11 -0     ports/net/silc-client/files/patch-apps__irssi__Makefile.in (new)
  1.2       +0 -25     ports/net/silc-client/files/patch-doc-Makefile.in (dead)
  1.1       +17 -0     ports/net/silc-client/files/patch-doc__Makefile.in (new)
  1.3       +0 -11     ports/net/silc-client/files/patch-irssi::src::core::network.c (dead)
  1.4       +0 -61     ports/net/silc-client/pkg-install (dead)
  1.21      +115 -112  ports/net/silc-client/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"