Bug 113652 - [patch] mail/dk-milter prefer shared link to static
Summary: [patch] mail/dk-milter prefer shared link to static
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-13 12:40 UTC by Hirohisa Yamaguchi
Modified: 2007-06-15 12:49 UTC (History)
0 users

See Also:

Attachments
file.diff (697 bytes, patch)
2007-06-13 12:40 UTC, Hirohisa Yamaguchi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hirohisa Yamaguchi 2007-06-13 12:40:03 UTC 
	ache@ has pointed that building milters static by default is
	not preferrable.

Fix: The patch follows
How-To-Repeat: 	# cd ports/mail/dk-milter
	# make build -DSENDMAIL_MILTER_IN_BASE
	# ldd work/$(make -V DISTNAME)/obj.$(uname -s).$(uname -r).$(uname -m)/dkim-filter/dkim-filter
	ldd: work/dkim-milter-1.0.0/obj.FreeBSD.7.0-CURRENT.amd64/dkim-filter/dkim-filter: not a dynamic executable
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-06-13 12:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2007-06-14 13:32:45 UTC 
State Changed
From-To: open->feedback


I agree th the chnage in general, but your patch seen to behave different:
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-06-15 12:33:07 UTC 
dinoex      2007-06-15 11:33:02 UTC

  FreeBSD ports repository

  Modified files:
    mail/dk-milter       Makefile 
  Log:
  - use bsd.milter.mk
  - fix bug in static-shared expression
  - fix shlibversion for shared milter
  - default now builds with shared milter
    Set option WITH_SENDMAIL_STATIC_MILTER=Yes to force static
  PR:             113652
  
  Revision  Changes    Path
  1.25      +15 -28    ports/mail/dk-milter/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Dirk Meyer freebsd_committer freebsd_triage 2007-06-15 12:48:38 UTC 
State Changed
From-To: feedback->closed

Thanks for feedback, 
I committed some more fixes.