Bug 113678 - net/rdesktop crashes after upgrading X.Org to 7.2
Summary: net/rdesktop crashes after upgrading X.Org to 7.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: David E. O'Brien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-14 13:10 UTC by Rashid N. Achilov
Modified: 2007-06-19 10:00 UTC (History)
0 users

See Also:


Attachments
file.diff (1.57 KB, patch)
2007-06-14 13:10 UTC, Rashid N. Achilov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rashid N. Achilov 2007-06-14 13:10:05 UTC
After upgrading X.Org to 7.2 rdesktop constantly crash with 'Segmentation
Fault'. I have search web and have discovered, that is a common problem - that
was many bureports, but none for FreeBSD? :-O No any FreeBSD user uses rdesktop
with ordinary office box, when DRI disabled (when DRI runs, bug doesn't
occured) ? :-O I have found a parital solution on some Debian forum, where was
told, that X11 now check on sanity for some parameters at XCreateImage and
returns NULL, when not satisifed. Rdesktop is very old program, it does not
check any return codes. So, I have looked at source code, read a man for
XCreateImage and detect a call for XCreateImage, which throws an exception. So,
I have search web again and found a patch at Ubuntu forum (he-he, Linux again
:-) ). When I have applied a patch, bug was eliminated. Also I have added some
debug code to point to exception source.

Fix: Patch attached

Patch attached with submission follows:
How-To-Repeat: Run rdesktop and login to any server. After succesful login rdesktop will crash
Comment 1 Pav Lucistnik freebsd_committer freebsd_triage 2007-06-14 16:09:52 UTC
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2007-06-19 09:54:10 UTC
State Changed
From-To: open->closed

Similar patch from different PR was committed.
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-06-19 09:55:19 UTC
pav         2007-06-19 08:55:11 UTC

  FreeBSD ports repository

  Modified files:
    net/rdesktop         Makefile 
  Added files:
    net/rdesktop/files   patch-xwin.c 
  Log:
  - Fix a crash on login for people running on X.org 7.2 in 24-bit color depth
  
  PR:             ports/113216, ports/113678
  Submitted by:   Thomas Spreng <spreng@socket.ch>
  Approved by:    maintainer timeout (obrien; 18 days)
  
  Revision  Changes    Path
  1.41      +1 -1      ports/net/rdesktop/Makefile
  1.1       +11 -0     ports/net/rdesktop/files/patch-xwin.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"