Update to 1.4.0 Remove 4.X support adjust pkg-plist Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback
Just want you to know that I am testing the patch, but need some more time to test the different options ('port test' gives me some errors). Edwin Groothuis wrote: > Maintainer of science/kst, > > Please note that PR ports/113750 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/113750 > >
Hi Kay, any news on this? Can the submitted patch be committed? Best regards, Stefan
Hello, I will try to work on it today. I got some errors with pkg-plist with some options. So I will have to fix it before it can be commited. Greetings, Kay Stefan Walter wrote: > Hi Kay, > > any news on this? Can the submitted patch be committed? > > Best regards, > Stefan >
So after testing the different options, I think we should commit it, but we need to mark it broken with cdf-support enabled. I did not get it to work right now and it needs some more work to do. But updating the port would be nice, since the new version is not that new any more. Attached is a patch against the official Makefile, which includes the Broken-statement. Greetings, Kay
On Sunday 30 September 2007, Kay Lehmann wrote: > So after testing the different options, I think we should commit it, but > we need to mark it broken with cdf-support enabled. I did not get it to > work right now and it needs some more work to do. But updating the port > would be nice, since the new version is not that new any more. Attached > is a patch against the official Makefile, which includes the > Broken-statement. > > Greetings, > Kay Both of kst 1.4.0 and 1.3.1 have an issue with cdf. During configure stage (with CDF defined): checking cdf.h usability... yes checking cdf.h presence... yes checking for cdf.h... yes checking for CDFlib in -lcdf... no from config.log: configure:34846: cc -o conftest -O2 -fno-strict-aliasing -pipe -D_THREAD_SAFE -pthread -DQT_THREAD_SUPPORT -I/usr/local/include -I/usr/local/include -I/usr/local/include -D_GETOPT_H -D_THREAD_SAFE -L/usr/local/lib -D_THREAD_SAFE -pthread -L/usr/local/lib conftest.c -lcdf -Wl,-export-dynamic -L/usr/local/lib -L/usr/local/lib -ljpeg -L/usr/local/lib >&5 /usr/local/lib/libcdf.so: undefined reference to `fmod' /usr/local/lib/libcdf.so: undefined reference to `pow' After adding -lm to LDFLAGS test passed successfully, but I haven't tried to compile kst.
You are right. Adding -lm helps a little bit, but I need to take a deeper look, because I got still some errors when both netcdf and cdf are enabled. Since it takes really long to compile I will need some time for my tests. So I would prefer to commit the patch and mark it broken until I found a solution. Thanks and best regards, Kay
So I made some tests again and found that the problems with kst are quite similar to my problems with mbdyn (pr: ports/114805). In this case the problem is quite weird: To disable automatic recognition of cdf and netcdf, when the user installs kst without enabling the corresponding options, the Makefile.in of the datasources-dir gets patched to not include the subdir of the named feature. So if we want to install both of them, we get the problem, that Makefile.in doesn't get patched and the original distributed Makrfile.in is older than Makefile.am and so gmake runs an automake-process which results in a Makefile which does not include all the subdirs of datasources and not all plugins/libs are installed =>pkg_plist gets broken, if both cdf and netcdf are enabled. So this is not a problem of cdf. I described a similar problem in the problem report for mbdyn and asked how somethiung like this should be solved, but I got no answer. I can think of some dirty work arounds but I think there must be an elegant/right way to fix this. Do you have any suggestions? Maybe I should open a thread on the ports-mailinglist? Thanks and greetings, Kay
Thanks again to Max. Attached is a patch which solves the problems with pkg-plist and it works quite well (at least for me). So I think the update could be commited without marking anything broken. Greets, Kay
State Changed From-To: feedback->open Feedback received.
Responsible Changed From-To: freebsd-ports-bugs->pav Let's have a go on this
State Changed From-To: open->closed Committed, thanks!
pav 2007-10-15 11:31:51 UTC FreeBSD ports repository Modified files: science/kst Makefile distinfo pkg-plist Log: - Update to 1.4.0 PR: ports/113750 Submitted by: Max Brazhnikov <makc@issp.ac.ru>, Kay Lehmann <kay_lehmann@web.de> (maintainer) Revision Changes Path 1.21 +3 -6 ports/science/kst/Makefile 1.7 +3 -3 ports/science/kst/distinfo 1.10 +838 -757 ports/science/kst/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"