- Update to 1.2
Class Changed From-To: update->maintainer-update Fix category (submitter is maintainer)
Responsible Changed From-To: freebsd-ports-bugs->chinsan I'll handle this. :)
Hi, Andy: On 7/18/07, Andy Kosela <andy.kosela@gmail.com> wrote: > --- bpkg-1.2.patch begins here --- > diff -ruN --exclude=CVS /usr/ports/ports-mgmt/bpkg/Makefile /usr/home/spear/downloads/bpkg-1.2/Makefile > --- /usr/ports/ports-mgmt/bpkg/Makefile Tue Jul 10 09:43:00 2007 > +++ /usr/home/spear/downloads/bpkg-1.2/Makefile Mon Jul 16 15:09:11 2007 > @@ -2,13 +2,13 @@ > -# $FreeBSD: ports/ports-mgmt/bpkg/Makefile,v 1.3 2007/07/10 07:43:00 miwi Exp $ > +# $FreeBSD$ > diff -ruN --exclude=CVS /usr/ports/ports-mgmt/bpkg/files/bpkg.sh.in /usr/home/spear/downloads/bpkg-1.2/files/bpkg.sh.in > --- /usr/ports/ports-mgmt/bpkg/files/bpkg.sh.in Tue Jul 10 09:43:01 2007 > +++ /usr/home/spear/downloads/bpkg-1.2/files/bpkg.sh.in Tue Jul 17 19:33:19 2007 > @@ -1,5 +1,5 @@ > #!/bin/sh > -# $FreeBSD: ports/ports-mgmt/bpkg/files/bpkg.sh.in,v 1.2 2007/07/10 07:43:01 miwi Exp $ > +# $FreeBSD$ $FreeBSD$ is a CVS id keyword which is common used in FreeBSD Project.(similar to $ID$). It's unnecessary to modify with them. :) http://www.freebsd.org/doc/en/books/porters-handbook/quick-porting.html#PORTING-MAKEFILE "Do not worry about the contents of the $FreeBSD$ line, it will be filled in automatically by CVS when the port is imported to our main ports tree." The others seems like okay. But maybe you should try to respect some important variables in the future. :) Such as $WRKDIRPREFIX, $PREFIX, $WRKDIRPREFIX and something else described in http://www.freebsd.org/doc/en/books/handbook/ports-using.html#AEN5731 and /usr/ports/Mk/bsd.ports.mk. Because I noticed that bpkg is using some absoulte path instead of respect the variables motioned above. BTW, your name is located at http://www.freebsd.org/doc/en/articles/contributors/contrib-additional.html. Sorry I gave you the wrong URL a few days ago. :p Cheers, - chinsan
State Changed From-To: open->feedback Awaiting maintainers feedback
Hi chinsan, For the most part bpkg.sh do not call bsd.port.mk at all, so there is no need to include those variables mentioned by you (only uses it when buidling ports from the source). Also in the case of -Z command line argument, some paths are absolute for the specific purpose of avoiding problems for users of old xorg-6.9. Just my perspective. 1.2 eliminates some serious bug in handling regexp package names, so please commit it as soon as it is possible. Thanks! Andy Kosela Pythagoras Foundation
chinsan 2007-07-23 10:54:18 UTC FreeBSD ports repository Modified files: ports-mgmt/bpkg Makefile ports-mgmt/bpkg/files bpkg.8 bpkg.sh.in Log: - Update to 1.2. PR: ports/114675 Submitted by: Andy Kosela Approved by: rafan (mentor) Revision Changes Path 1.4 +1 -1 ports/ports-mgmt/bpkg/Makefile 1.3 +2 -2 ports/ports-mgmt/bpkg/files/bpkg.8 1.3 +151 -135 ports/ports-mgmt/bpkg/files/bpkg.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks.