Bug 115077 - graphics/libungif: reduce X dependencies
Summary: graphics/libungif: reduce X dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-31 11:30 UTC by Martin Matuska
Modified: 2007-08-26 17:00 UTC (History)
0 users

See Also:


Attachments
file.diff (676 bytes, patch)
2007-07-31 11:30 UTC, Martin Matuska
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Matuska freebsd_committer freebsd_triage 2007-07-31 11:30:07 UTC
This port requires only USE_XORG= xt
(tested with tinderbox)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-31 11:30:14 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

Over to maintainer
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2007-08-15 10:54:25 UTC
State Changed
From-To: open->feedback

1. ldd suggests this line: 
USE_XLIB=	sm ice x11 xau xdmcp 

2. the dependency list is not really changed 
make all-depends-list 
has still the same output, so a bump seem not be necessary.
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2007-08-16 11:58:02 UTC
1. not USE_XLIB= .... but USE_XORG= ....
that makes a huge difference, you get the same dependency list if
USE_XLIB is still there (value of USE_XLIB is not considered)
PORTREVISION bump is necessary
(I was already taught by pav and kris to always include it when
switching USE_XLIB->USE_XORG)

2. USE_XORG= xt is not really necessary (it includes sm and x11, but we
do not need libXt),
but we do not need to state all of the libs, too:

a) if you do a ldd on libX11 you get libXau and libXdmcp as deps (x11
includes xau + xdmcp)
b) if you do a ldd on libSM you get libICE as a dep (sm includes ice)

that means I correct myself to:
USE_XORG=sm x11

Here are some tb logs for USE_XORG=sm x11:
http://amd64.vx.sk/logs/6.2-FreeBSD-amd64/libungif-4.1.4_4.log
http://i386.vx.sk/logs/6.2-FreeBSD-i386/libungif-4.1.4_4.log
http://amd64.vx.sk/logs/5.5-FreeBSD-amd64/libungif-4.1.4_4.log
http://i386.vx.sk/logs/5.5-FreeBSD-i386/libungif-4.1.4_4.log

Thanks.
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-08-18 22:10:48 UTC
dinoex      2007-08-18 21:10:42 UTC

  FreeBSD ports repository

  Modified files:
    graphics/libungif    Makefile 
  Log:
  - list detailed dependencies
  PR:             115077
  Submitted by:   mm
  
  Revision  Changes    Path
  1.40      +2 -2      ports/graphics/libungif/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2007-08-19 10:05:26 UTC
State Changed
From-To: feedback->closed


I checked whcih libs are linked in directly: 

cd /usr/ports/current/libungif && make configure 

wcd 

grep LIBS Makefile 
LIBS =  
X_EXTRA_LIBS =  
X_LIBS =  -L/usr/local/lib 
X_PRE_LIBS =  -lSM -lICE 

committed with small changes, thanks.
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-08-26 16:51:20 UTC
mm          2007-08-26 15:51:14 UTC

  FreeBSD ports repository

  Modified files:
    graphics/libungif    Makefile 
  Log:
  - Replace USE_XLIB with USE_XORG=sm x11
  - Bump PORTREVISION
  
  PR:             ports/115077
  Approved by:    dinoex (maintainer, private e-mail)
  
  Revision  Changes    Path
  1.41      +2 -2      ports/graphics/libungif/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"