Fix: Patch attached with submission follows:
Class Changed From-To: change-request->maintainer-update Fix category (submitter is maintainer)
State Changed From-To: open->feedback Please submit updates as unified diffs, see /usr/share/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html
On Fri, 17 Aug 2007 16:01:41 +0200 Petr Macek <pm@kostax.cz> wrote: > Enclosed I am sending file with unified diffs as you requested. Thank you. > Is it ok to send this file to you only, or should I send it to > send-pr too? You should always submit updates like this; it makes it much easier to handle them (patch the port after a CVS checkout and inspect the changes). You might find this little link useful: http://sce-tindy.tecnik93.com/FreeBSD/How-to-submit-a-diff.txt Also all important data regarding a PR should be in that PR, so yes, you should reply to the GNATS email so that your diff enters the bug database. (As you can see I didn't took you PR so your private email might get lost; what's in GNATS doesn't get lost and some other commiter can act on it; I have cc'ed GNATS address so when you reply please reply to the mail from GNATS, not to my email). > Please check this diff file, it's first time I made something like > that. See my comments bellow (quick glance): diff -ruN mywwwatcher.bak/Makefile mywwwatcher/Makefile --- mywwwatcher.bak/Makefile Fri Aug 17 15:42:00 2007 +++ mywwwatcher/Makefile Thu Aug 16 21:10:55 2007 @@ -1,30 +1,30 @@ -# New ports collection makefile for: mywwwatcher -# Date created: 10 January 2007 +# New ports collection makefile for: mywwwatcher +# Date created: 16. August 2007 # Whom: Petr Macek <pm@kostax.cz> We don't modify this header. # -# $FreeBSD: ports/databases/mywwwatcher/Makefile,v 1.1 2007/01/12 10:15:49 itetcu Exp $ +# $FreeBSD$ Never do this. # PORTNAME= mywwwatcher -PORTVERSION= 3.0 -CATEGORIES= databases www +PORTVERSION= 3.1 +CATEGORIES= www databases Why this change in the categories order ? This would imply a repo-copy from databases to www prior to updating. And the port's primary category is OK IMO. MASTER_SITES= http://www.the.cz/mywwwatcher/files/ DISTNAME= mywwwatcher-${PORTVERSION} MAINTAINER= pm@kostax.cz -COMMENT= Simply web-based mysql client + tools (dump, import, scheme, ...) +COMMENT= Simply web-based mysql client + tools (dump, import, scheme, ...) WRKSRC= ${WRKDIR}/mywwwatcher -DEFAULT_PHP_VER= 4 -USE_PHP= pcre session mysql +DEFAULT_PHP_VER= 5 +USE_PHP= pcre session mysql NO_BUILD= yes PKGMESSAGE= ${PKGDIR}/pkg-message PLIST_SUB+= INSTALLDIR=${INSTALLDIR} -INSTALLDIR= www/${PORTNAME} +INSTALLDIR= www/data-dist/mywwwatcher Wrong. Web ports should install in WWWDIR which defaults to ${PREFIX}/www/${PORTNAME}, so you can drop this line and s/INSTALLDIR/WWWDIR/g in the rest of the Makefile and pkg-plist. Since this is 'web-based' you should also add WANT_PHP_WEB=yes to the Makefile. The rest looks OK (I haven't test it). I will take the PR now and wait for your new diff that fixes the things above. Thanks for your work, -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect"
Responsible Changed From-To: freebsd-ports-bugs->itetcu I'll take it.
I am sending fixed version of unified diff. PM Ion-Mihai Tetcu napsal(a): > On Fri, 17 Aug 2007 16:01:41 +0200 > Petr Macek <pm@kostax.cz> wrote: > >> Enclosed I am sending file with unified diffs as you requested. > > Thank you. > >> Is it ok to send this file to you only, or should I send it to >> send-pr too? > > You should always submit updates like this; it makes it much easier to > handle them (patch the port after a CVS checkout and inspect the > changes). You might find this little link useful: > http://sce-tindy.tecnik93.com/FreeBSD/How-to-submit-a-diff.txt > > Also all important data regarding a PR should be in that PR, so yes, > you should reply to the GNATS email so that your diff enters the bug > database. (As you can see I didn't took you PR so your private email > might get lost; what's in GNATS doesn't get lost and some other > commiter can act on it; I have cc'ed GNATS address so when you reply > please reply to the mail from GNATS, not to my email). > >> Please check this diff file, it's first time I made something like >> that. > > > See my comments bellow (quick glance): > > diff -ruN mywwwatcher.bak/Makefile mywwwatcher/Makefile > --- mywwwatcher.bak/Makefile Fri Aug 17 15:42:00 2007 > +++ mywwwatcher/Makefile Thu Aug 16 21:10:55 2007 > @@ -1,30 +1,30 @@ > -# New ports collection makefile for: mywwwatcher > -# Date created: 10 January 2007 > +# New ports collection makefile for: mywwwatcher > +# Date created: 16. August 2007 > # Whom: Petr Macek <pm@kostax.cz> > > We don't modify this header. > > # > -# $FreeBSD: ports/databases/mywwwatcher/Makefile,v 1.1 2007/01/12 10:15:49 itetcu Exp $ > +# $FreeBSD$ > > Never do this. > > # > > PORTNAME= mywwwatcher > -PORTVERSION= 3.0 > -CATEGORIES= databases www > +PORTVERSION= 3.1 > +CATEGORIES= www databases > > Why this change in the categories order ? This would imply a repo-copy > from databases to www prior to updating. And the port's primary > category is OK IMO. > > MASTER_SITES= http://www.the.cz/mywwwatcher/files/ > DISTNAME= mywwwatcher-${PORTVERSION} > > MAINTAINER= pm@kostax.cz > -COMMENT= Simply web-based mysql client + tools (dump, import, scheme, ...) > +COMMENT= Simply web-based mysql client + tools (dump, import, scheme, ...) > > WRKSRC= ${WRKDIR}/mywwwatcher > > -DEFAULT_PHP_VER= 4 > -USE_PHP= pcre session mysql > +DEFAULT_PHP_VER= 5 > +USE_PHP= pcre session mysql > > NO_BUILD= yes > > PKGMESSAGE= ${PKGDIR}/pkg-message > PLIST_SUB+= INSTALLDIR=${INSTALLDIR} > > -INSTALLDIR= www/${PORTNAME} > +INSTALLDIR= www/data-dist/mywwwatcher > > Wrong. Web ports should install in WWWDIR which defaults to > ${PREFIX}/www/${PORTNAME}, so you can drop this line and > s/INSTALLDIR/WWWDIR/g in the rest of the Makefile and pkg-plist. > > Since this is 'web-based' you should also add WANT_PHP_WEB=yes to the > Makefile. > > The rest looks OK (I haven't test it). I will take the PR now and wait > for your new diff that fixes the things above. > > > Thanks for your work, > -- # --------------- # Petr Macek # pm@kostax.cz # icq: 87323239 # www.kostax.cz # MySQL www client (PHP) ... try it! # http://the.cz/mywwwatcher
State Changed From-To: feedback->open new patch received
itetcu 2007-08-24 16:43:59 UTC FreeBSD ports repository Modified files: databases/mywwwatcher Makefile distinfo pkg-plist Removed files: databases/mywwwatcher pkg-message Log: - update to 3.1 - WANT_PHP_WEB since it's web-based - default php to 5 and mark ignore with 3 - use WWWDIR - use SUB_FILES for pkg-message PR: ports/115584 Submitted by: Petr Macek (maintainer) Revision Changes Path 1.2 +10 -10 ports/databases/mywwwatcher/Makefile 1.2 +3 -3 ports/databases/mywwwatcher/distinfo 1.2 +0 -5 ports/databases/mywwwatcher/pkg-message (dead) 1.2 +44 -44 ports/databases/mywwwatcher/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
itetcu 2007-08-24 16:45:48 UTC FreeBSD ports repository Added files: databases/mywwwatcher/files pkg-message.in Log: Add file forgotten in previous commit: - update to 3.1 - WANT_PHP_WEB since it's web-based - default php to 5 and mark ignore with 3 - use WWWDIR - use SUB_FILES for pkg-message PR: ports/115584 Submitted by: Petr Macek (maintainer) Revision Changes Path 1.1 +14 -0 ports/databases/mywwwatcher/files/pkg-message.in (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!