Bug 115841 - [MAINTAINER UPDATE] ftp/bsdftpd-ssl: fix problems with gcc 4
Summary: [MAINTAINER UPDATE] ftp/bsdftpd-ssl: fix problems with gcc 4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-26 22:30 UTC by Nick Leuta
Modified: 2007-08-30 19:00 UTC (History)
0 users

See Also:


Attachments
file.diff (8.07 KB, patch)
2007-08-26 22:30 UTC, Nick Leuta
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Leuta 2007-08-26 22:30:02 UTC
This port can't be compiled in -CURRENT

Fix: Tested with 7.0-CURRENT-200708 snapshot on amd64 and i386 platforms.
Comment 1 Sergey Matveychuk freebsd_committer freebsd_triage 2007-08-30 16:19:31 UTC
It's a quite strange way to fix build:
+-               BIO_printf(out, "write to %08X (%d bytes => %ld (%X))\n",
+-                         bio, argi, ret, ret);
++/*             BIO_printf(out, "write to %08X (%d bytes => %ld (%X))\n",
++                         bio, argi, ret, ret);*/

It looks like a functional change.
Are you sure?
-- 
Dixi.
Sem.
Comment 2 Nick Leuta 2007-08-30 17:14:35 UTC
Sergey Matveychuk wrote:
> It's a quite strange way to fix build:
> +-               BIO_printf(out, "write to %08X (%d bytes => %ld (%X))\n",
> +-                         bio, argi, ret, ret);
> ++/*             BIO_printf(out, "write to %08X (%d bytes => %ld (%X))\n",
> ++                         bio, argi, ret, ret);*/
> 
> It looks like a functional change.
> Are you sure?

Yes, I am sure. As a developer of this program I think that those lines 
can be removed at all ;) (because they implement very rarely used 
debugging capabilities)

Those lines are the legacy of the "old good times" of ssleay (the 
predecessor of OpenSSL)...

-- 
SkyNick
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-08-30 18:58:22 UTC
sem         2007-08-30 17:58:16 UTC

  FreeBSD ports repository

  Modified files:
    ftp/bsdftpd-ssl      Makefile 
  Added files:
    ftp/bsdftpd-ssl/files patch-gcc4 
  Log:
  - Patch to fix build with gcc 4.x
  - PORTREVISION bump because some minor functional changes.
  
  PR:             ports/115841
  Submitted by:   maintainer
  
  Revision  Changes    Path
  1.8       +1 -1      ports/ftp/bsdftpd-ssl/Makefile
  1.1       +257 -0    ports/ftp/bsdftpd-ssl/files/patch-gcc4 (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Sergey Matveychuk freebsd_committer freebsd_triage 2007-08-30 18:58:44 UTC
State Changed
From-To: open->closed

Committed. Thanks!