Update dosbox to 0.72 Makefile optimization. Fix: Patch attached with submission follows:
State Changed From-To: open->feedback Awaiting maintainers feedback
Looks good.
State Changed From-To: feedback->open Maintainer approved.
Responsible Changed From-To: freebsd-ports-bugs->araujo I'll take it.
Dear Maintainer and Alex Kozlov! - Why you removed pkg-plist? With the pkg-plist becomes the port more legible! - Please respect NOPORTDOCS. You should maintain NOPORTDOCS equal the current version. Thanks! -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
Hi, araujo > - Why you removed pkg-plist? > With the pkg-plist becomes the port more legible! This ports installs only a few files. http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-desc.html#AEN98 >- Please respect NOPORTDOCS. >You should maintain NOPORTDOCS equal the current version. Yes. Sorry. Please remove @${ECHO_CMD} "@dirrm ${DOCSDIR:S,^${PREFIX}/,,}" >> ${TMPPLIST} and add just below PLIST: .if !defined(NOPORTDOCS) PLIST_DIRS= %%DOCSDIR%% .endif -- Adios
This is a multi-part message in MIME format.
On Wed, Aug 29, 2007 at 10:14:29AM -0300, Marcelo Araujo wrote: > Alex Kozlov wrote: > > Yes. Sorry. > > Please remove @${ECHO_CMD} "@dirrm ${DOCSDIR:S,^${PREFIX}/,,}" >> ${TMPPLIST} > > and add just below PLIST: > > > > .if !defined(NOPORTDOCS) > > PLIST_DIRS= %%DOCSDIR%% > > .endif > > I reworked this patch, I'm waiting your approval. > Tinderbox LOG: http://200.247.114.5/tb/logs/6.2-RELEASE/dosbox-0.72.log You should get approval from Tom. I just want update dosbox to current version. btw, 'USE_GCC= 3.2+' is for 4.x compatability. If You remove its, you may also remove: files/patch-src::cpu::core_dyn_x86.cpp files/patch-src::dos::cdrom_image.cpp -- Adios
Alex Kozlov wrote: > > btw, 'USE_GCC= 3.2+' is for 4.x compatability. > If You remove its, you may also remove: > files/patch-src::cpu::core_dyn_x86.cpp > files/patch-src::dos::cdrom_image.cpp > > > -- > Adios > > Alex, You touched in a good point! Like the 4.X is not more supported, you should remove this patch and send the diff again! You can do a new patch? Thanks. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
On Wed, Aug 29, 2007 at 00:14:34PM -0300, Marcelo Araujo wrote: > Alex Kozlov wrote: > > > > btw, 'USE_GCC= 3.2+' is for 4.x compatability. > > If You remove its, you may also remove: > > files/patch-src::cpu::core_dyn_x86.cpp > > files/patch-src::dos::cdrom_image.cpp > > > Alex, > > You touched in a good point! > Like the 4.X is not more supported, you should remove this patch and > send the diff again! > > You can do a new patch? > > Thanks. Personally I think that removing 4.x compatibility little to early. But again, if you get permission from maintainer, I have no problem with it. I looked at your diff more closely. Why you removed man page? -- Adios
Marcelo Araujo wrote: > Hi Alex, > Removing 4.x is not a option, you understand? The 4.x is EOL or unsupport= > ed! > About MANPAGE, you tested the patch? > I did another patch, I removed support of 4.x(EOL) and reworked the > Makefile. > > > Ooops, I forgot to install manpage :) Fixed, look at: http://people.freebsd.org/~araujo/logs/dosbox.diff Best Regards. -- Marcelo Araujo (__) araujo@FreeBSD.org \\\'',) http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)
On Thu, Aug 30, 2007 at 08:03:43AM -0300, Marcelo Araujo wrote: > Alex Kozlov wrote: > > On Wed, Aug 29, 2007 at 00:14:34PM -0300, Marcelo Araujo wrote: > > > > Personally I think that removing 4.x compatibility little to early. But > > again, if you get permission from maintainer, I have no problem with it. > > > > I looked at your diff more closely. Why you removed man page? > > > Hi Alex, > Removing 4.x is not a option, you understand? The 4.x is EOL or unsupported! > About MANPAGE, you tested the patch? Yes. I can see man only after adding back MAN1= dosbox.1 ${INSTALL_MAN} ${WRKSRC}/docs/dosbox.1 ${PREFIX}/man/man1/ Also, SEE ALSO manual section specifies in a wrong place if I not return @${REINPLACE_CMD} -e 's#\/usr\/share\/doc\/dosbox#${DOCSDIR}#g' \ ${WRKSRC}/docs/dosbox.1 > I did another patch, I removed support of 4.x(EOL) and reworked the > Makefile. -- Adios
On Thu, 30 Aug 2007 08:03:43 -0300 Marcelo Araujo <araujobsdport@gmail.com> wrote: > Alex Kozlov wrote: > > On Wed, Aug 29, 2007 at 00:14:34PM -0300, Marcelo Araujo wrote: > > > > Personally I think that removing 4.x compatibility little to early. > > But again, if you get permission from maintainer, I have no problem > > with it. > > > > I looked at your diff more closely. Why you removed man page? > > Removing 4.x is not a option, you understand? The 4.x is EOL or > unsupported! About MANPAGE, you tested the patch? It won't matter if you support 4.x inside a port or not since newer versions of bsd.*.mk won't work. So yes, support for 4.x should be removed from ports. You are right about the man page. -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect"
araujo 2007-09-19 18:21:39 UTC FreeBSD ports repository Modified files: emulators/dosbox Makefile distinfo pkg-plist Removed files: emulators/dosbox pkg-message emulators/dosbox/files patch-configure.in patch-src::cpu::core_dyn_x86.cpp patch-src::dos::cdrom_image.cpp Log: - Update to 0.72. - Remove 4.X cruft. PR: ports/115859 Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> Approved by: stas (mentor), Tom Carrick <knyght@gmail.com> (maintainer) Revision Changes Path 1.19 +3 -10 ports/emulators/dosbox/Makefile 1.12 +3 -3 ports/emulators/dosbox/distinfo 1.3 +0 -10 ports/emulators/dosbox/files/patch-configure.in (dead) 1.2 +0 -11 ports/emulators/dosbox/files/patch-src::cpu::core_dyn_x86.cpp (dead) 1.3 +0 -11 ports/emulators/dosbox/files/patch-src::dos::cdrom_image.cpp (dead) 1.2 +0 -4 ports/emulators/dosbox/pkg-message (dead) 1.5 +1 -0 ports/emulators/dosbox/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks!