Bug 115966 - [UPDATE] ports/ftp/bsdftpd-ssl: set LANG=C while doing character translations
Summary: [UPDATE] ports/ftp/bsdftpd-ssl: set LANG=C while doing character translations
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Beech Rintoul
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-31 14:10 UTC by Sunpoet Po-Chuan Hsieh
Modified: 2007-09-07 20:40 UTC (History)
0 users

See Also:

Attachments
file.diff (567 bytes, patch)
2007-08-31 14:10 UTC, Sunpoet Po-Chuan Hsieh 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sunpoet Po-Chuan Hsieh 2007-08-31 14:10:01 UTC 
bsdftpd-ssl's makelist script uses tr to do character translations.
It may yield unexpected results with some locales (eg en_US.UTF-8).
Use LANG=C explicitly to avoid this build error.

Fix: # cat /usr/ports/ftp/bsdftpd-ssl/files/patch-contrib-libedit-makelist
How-To-Repeat: # sh
# env LANG=en_US.UTF-8
# cd /usr/ports/ftp/bsdftpd-ssl
# make
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-31 14:10:10 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->beech

beech@ wants this category PRs
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-31 14:10:18 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Nick Leuta 2007-09-03 17:45:59 UTC 
Well, it's possible to accept this patch. I agree.

But in future it will be better to patch ftp client and to use FreeBSD's 
stock libedit... It will break compatibility with 4.X branch (I think 
that it isn't a problem now ;) ), and I don't sure about 5.X (I think 
that it will work, just need to check).

But this work will take a time... So, I propose to accept this patch now 
and to patch ftp client in future.

-- 
SkyNick

Edwin Groothuis wrote:
> Maintainer of ftp/bsdftpd-ssl,
> 
> Please note that PR ports/115966 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/115966
>
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2007-09-03 23:34:26 UTC 
State Changed
From-To: feedback->open

Maintainer approved
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-09-07 20:31:47 UTC 
beech       2007-09-07 19:31:41 UTC

  FreeBSD ports repository

  Added files:
    ftp/bsdftpd-ssl/files patch-contrib-libedit-makelist 
  Log:
  - Add patch - Set LANG=C while doing character translations.
  
  PR:             ports/115966
  Submitted by:   Sunpoet Po-Chuan Hsieh <sunpoet@sunpoet.net>
  Approved by:    Nick Leuta <skynick@mail.sc.ru> (maintainer),
                  sat (mentor)
  
  Revision  Changes    Path
  1.1       +15 -0     ports/ftp/bsdftpd-ssl/files/patch-contrib-libedit-makelist (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Beech Rintoul freebsd_committer freebsd_triage 2007-09-07 20:32:09 UTC 
State Changed
From-To: open->closed

Committed, Thanks!