Received email stating "build fails on amd64 system with a message about unsupported instructions. [...] Modifying patch-Makefile so that -m486 / -mtune 486 option is removed fixed the problem for me." Updated Makefile to add PORTREVISION so that updates will be seen by ports-tools, implemented arch suggestions for fixes, removing most mention of architecture specific instructions. Those will likely be in make.conf, anyway, and if so will be passed along due to inclusion. Fix: ---------------------------------------------------------------------- Free pop3 email with a spam filter. http://www.bluebottle.com/tag/5--7LfAJg5kxXaqa6HxznYUGdP3ekWqeDUmSUj3BGmLAWl2K5kW Content-Type: text/plain; name="file.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="file.diff" diff -ruN games/crafty/Makefile games/crafty/Makefile.orig --- games/crafty/Makefile Tue Sep 11 12:59:05 2007 +++ games/crafty/Makefile Sat Sep 15 14:37:47 2007 @@ -7,6 +7,7 @@ PORTNAME= crafty PORTVERSION= 20.14 +PORTREVISION= 1 CATEGORIES= games MASTER_SITES= ftp://ftp.cis.uab.edu/pub/hyatt/pgn/:data \ ftp://ftp.cis.uab.edu/pub/hyatt/documentation/:doc \ @@ -54,14 +55,6 @@ .if ${ARCH} == "i386" OPT+= -DINLINE32 -# XXX Someone with ASM knowledge would have to fix the Sparc.S -.elif ${ARCH} == "sparc64" -OPT+= -DINLINE32 -CFLAGS+= '$(CFLAGS) -D_REENTRANT -O3 -Wall \ - -fomit-frame-pointer -funroll-all-loops \ - -finline-functions -ffast-math' \ -.else -OPT+= -DFAST .endif MAKE_ENV+= opt="${OPT}" target=${OPSYS} CXFLAGS="${CXXFLAGS}" --- games/crafty/files/patch-Makefile.orig Sun Sep 9 19:11:54 2007 +++ games/crafty/files/patch-Makefile Sat Sep 15 14:39:45 2007 @@ -8,7 +8,7 @@ - CXFLAGS=$(CFLAGS) \ - LDFLAGS=$(LDFLAGS) \ - opt='$(opt) -DINLINE32' \ -+ CFLAGS+='-fomit-frame-pointer -mtune=i486 -O3 -Wall' \ ++ CFLAGS+='-fomit-frame-pointer -Wall' \ + CXFLAGS+='$(CXXFLAGS)' \ + LDFLAGS='$(LDFLAGS) -lstdc++' \ + opt='$(opt)' \ How-To-Repeat: Compile on amd64 (others as well, likely)
State Changed From-To: open->closed Committed, thanks!
edwin 2007-09-23 03:44:46 UTC FreeBSD ports repository Modified files: games/crafty Makefile games/crafty/files patch-Makefile Log: [Maintainer Update]: fix arch-related issues Received email stating "build fails on amd64 system with a message about unsupported instructions. [...] Modifying patch-Makefile so that -m486 / -mtune 486 option is removed fixed the problem for me." Updated Makefile to add PORTREVISION so that updates will be seen by ports-tools, implemented arch suggestions for fixes, removing most mention of architecture specific instructions. Those will likely be in make.conf, anyway, and if so will be passed along due to inclusion. PR: ports/116379 Submitted by: shoemaker@bluebottle.com (Jonathan Shoemaker) Revision Changes Path 1.35 +2 -9 ports/games/crafty/Makefile 1.2 +1 -1 ports/games/crafty/files/patch-Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"