Bug 116690 - Update port: devel/rlwrap fix broken pty search on devfs
Summary: Update port: devel/rlwrap fix broken pty search on devfs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Frank J. Laszlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-27 14:20 UTC by Martin Kammerhofer
Modified: 2007-10-07 23:00 UTC (History)
0 users

See Also:


Attachments
file.diff (2.17 KB, patch)
2007-09-27 14:20 UTC, Martin Kammerhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kammerhofer 2007-09-27 14:20:01 UTC
The configure script of the devel/rlwrap port searches for the names
of pseudo terminals. Found /dev/pty?? files are then hard-coded into
the $PREFIX/bin/rlwrap executable.

This does not work well with FreeBSD where /dev/* nodes are
dynamic. The resulting behaviour is highly undesirable: Only pseudo
terminals in use at configure time are considered. If none of those is
free at run time then pseudo tty allocation fails with a fatal error!

The fix is of course to let the binary know about valid pseudo tty
names on FreeBSD, i.e. /dev/[pt]ty[p-sP-S][0-9a-v].

While at it also s/PREFIX/LOCALBASE/ where appropriate.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-09-28 00:11:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->laszlof

Over to maintainer
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-10-07 22:52:08 UTC
laszlof     2007-10-07 21:51:57 UTC

  FreeBSD ports repository

  Modified files:
    devel/rlwrap         Makefile 
    devel/rlwrap/files   patch-src::ptytty.c 
  Log:
  FIx bug reported by submitter
  remove checks for readline 4.2+, we do not support 4.x anymore
  bump PORTREVISION
  
  PR:             ports/116690
  Submitted by:   Martin Kammerhofer <dada@pluto.tugraz.at>
  
  Revision  Changes    Path
  1.25      +4 -15     ports/devel/rlwrap/Makefile
  1.3       +27 -2     ports/devel/rlwrap/files/patch-src::ptytty.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Frank J. Laszlo freebsd_committer freebsd_triage 2007-10-07 22:52:11 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!