When I was taking code from the wrapper script for a new port (databases/exist), I saw 2 problems in it: 1) When the daemon is not running, 'procname' is empty and the call to check_pidfile fails. 2) The use of *$procname* causes shell expansion, and together with the previous one, generates an error because ** matches every file in the directory. Note: these errors do not stop the script from working, but might produce strange results (for example the output) in some situations. How-To-Repeat: Run when the daemon is not started: ${PREFIX}/etc/rc.d/tomcat66.sh forcestop Apply the patch, and run again.
Responsible Changed From-To: freebsd-ports-bugs->alepulver Submitter has GNATS access
State Changed From-To: open->feedback Awaiting maintainers feedback
alepulver 2007-09-30 22:04:02 UTC FreeBSD ports repository Modified files: www/tomcat41/files tomcat41.sh.in www/tomcat55/files tomcat55.sh.in www/tomcat6/files tomcat6.sh.in Log: - Fix problems with the "status" command in the wrapper script when the daemon is not started. PR: ports/116729 Submitted by: alepulver (myself) Approved by: "Tong Liu" <nemoliu@gmail.com> (maintainer of tomcat{41,6}), Tomas Verbaitis <tomasv@megalogika.lt> (maintainer of tomcat55) Revision Changes Path 1.6 +5 -2 ports/www/tomcat41/files/tomcat41.sh.in 1.7 +5 -2 ports/www/tomcat55/files/tomcat55.sh.in 1.2 +5 -2 ports/www/tomcat6/files/tomcat6.sh.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!