Bug 116907 - ports-mgmt/portlint: doesn't allow USE_JAVA after bsd.port.pre.mk
Summary: ports-mgmt/portlint: doesn't allow USE_JAVA after bsd.port.pre.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-04 16:20 UTC by Naram Qashat
Modified: 2007-12-15 17:50 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2007-10-04 16:20:09 UTC
Currently, portlint will output a FATAL error when USE_JAVA is placed below
the include of bsd.port.pre.mk, but I talked to the maintainer of bsd.java.mk
and he said it's perfectly fine to put USE_JAVA after bsd.port.pre.mk.

Fix: 

I do not know Perl, otherwise I would've figured out how to patch portlint,
but it needs to be patched so it allows the use of USE_JAVA after the inclusion
of bsd.port.pre.mk
How-To-Repeat: Use portlint on any port that has USE_JAVA after including bsd.port.pre.mk
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-10-04 16:20:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->marcus

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2007-10-22 17:48:36 UTC
State Changed
From-To: open->patched

Fix is committed to my local CVS repo pending the next portlint release.
Comment 3 dfilter service freebsd_committer freebsd_triage 2007-12-15 17:40:23 UTC
marcus      2007-12-15 17:40:19 UTC

  FreeBSD ports repository

  Modified files:
    ports-mgmt/portlint  Makefile 
    ports-mgmt/portlint/src portlint.pl 
  Log:
  Update to 2.9.6.
  
  * Allow the @stopdaemon plist directive. [1]
  * Fix a typo when checking for proper use of DOCSDIR. [2]
  * USE_JAVA is okay to use after including bsd.port.pre.mk. [3]
  * Properly check for extra items in the PATCH_SITES section. [4]
  * Replace all instances of "IFF" with "If and only if" to be clearer for
    non-English speaking, non-math geeks. [5]
  
  PR:             116907 [3]
                  116698 [4]
                  116218 [5]
  Reported by:    rafan [1]
  Submitted by:   lwhsu [2]
  
  Revision  Changes    Path
  1.119     +1 -1      ports/ports-mgmt/portlint/Makefile
  1.96      +29 -27    ports/ports-mgmt/portlint/src/portlint.pl
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Joe Marcus Clarke freebsd_committer freebsd_triage 2007-12-15 17:40:37 UTC
State Changed
From-To: patched->closed

Fixed in 2.9.6.