Add FLV2MPEG4 option to convert flv to avi using multimedia/flv2mpeg4 (3+ times faster and less lossy than ffmpeg). Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->itetcu itetcu@ wants his PRs (via the GNATS Auto Assign Tool)
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Tried flv2mpeg4. IMO it's results are much better than ffmpeg. Thanks for a good pointer! Also, I like your patch with one exception: I hate creating temporary files if it can be easily avoided. ffmpeg has an ability to read data from stdin and flv2mpeg doesn't. I have just submitted a patch to solve this problem: http://sourceforge.net/tracker/index.php?func=detail&aid=1814075&group_id=183657&atid=906124 As soon as the stdin patch will make it's way to ports (either as an upstream release or as a local FreeBSD patch), I will approve this patch. Thank you!
On Mon, Oct 15, 2007 at 11:16:39PM +0400, Pankov Pavel wrote: > Tried flv2mpeg4. IMO it's results are much better than ffmpeg. Thanks for a > good pointer! Also, I like your patch with one exception: I hate creating > temporary files if it can be easily avoided. ffmpeg has an ability to read > data from stdin and flv2mpeg doesn't. I have just submitted a patch to solve > this problem: > http://sourceforge.net/tracker/index.php?func=detail&aid=1814075&group_id=183657&atid=906124 > As soon as the stdin patch will make it's way to ports (either as an upstream > release or as a local FreeBSD patch), I will approve this patch. Thank you! Chances that your patch will be accepted upstream is not very high. I tried to contact the authors of flv2mpeg4 several times, but so far without success. But perhaps you are more lucky. Also your patch just does not work. If I try feed flv2mpeg from stdin I get 'header error!!' message: $cat infile.flv | ./flv2mpeg4_stdin - outfile.avi header error!! $cat infile.flv | flv2mpeg4 /dev/stdin outfile.avi header error!! And last but not least. I do not think that a temporary file completely useless. If in conversion process we run out of space or power failure occurs, or other error, valid flv file will remain. -- Adios
> Chances that your patch will be accepted upstream is not very high. I tried > to contact the authors of flv2mpeg4 several times, but so far without > success. But perhaps you are more lucky. I just didn't know about /dev/stdin :) Now this patch is just a matter of style and adds zero functionality. Thanks! :) > Also your patch just does not work. If I try feed flv2mpeg from stdin > I get 'header error!!' message: > $cat infile.flv | ./flv2mpeg4_stdin - outfile.avi > header error!! > $cat infile.flv | flv2mpeg4 /dev/stdin outfile.avi > header error!! It seems to be cat-related problems (non-printable characters or buffer issues, I think), as shell redirection works just fine: $ flv2mpeg4 /dev/stdin qjLo7Dd2zA8.avi < qjLo7Dd2zA8.flv $ ls qjLo7Dd2zA8.avi qjLo7Dd2zA8.avi I have no time to look deeper into this. > And last but not least. I do not think that a temporary file completely > useless. If in conversion process we run out of space or power failure > occurs, or other error, valid flv file will remain. Reasonable. Updated patch attached. It: - Updates www/youtube_dl to 2007.10.12 (no functional changes: only one \n added) - Adds an ability to use multimedia/flv2mpeg4 for conversion [1] Submitted by: Alex Kozlov <spam@rm-rf.kiev.ua> [1] itetcu@, could you please commit it?
Responsible Changed From-To: itetcu->freebsd-ports-bugs With bugmeister hat on, reset itetcu's ownership of this one, since he has been inactive for some time.
I have just submitted the patch adding the FLV2MPEG4 option as a follow up for ports/120005 PR. Thank you!
obrien 2008-02-04 10:08:39 UTC FreeBSD ports repository Modified files: www/youtube_dl Makefile distinfo Added files: www/youtube_dl/files conv2avi.patch Removed files: www/youtube_dl/files ffmpeg.patch Log: + Updates www/youtube_dl to 2008.01.24 [1][2] + Adds an ability to use multimedia/flv2mpeg4 for conversion [3] Submitted by: Pankov Pavel <pankov_p@mail.ru> PR: 119990, 120005, 117053 Revision Changes Path 1.16 +18 -4 ports/www/youtube_dl/Makefile 1.15 +3 -3 ports/www/youtube_dl/distinfo 1.1 +74 -0 ports/www/youtube_dl/files/conv2avi.patch (new) 1.3 +0 -60 ports/www/youtube_dl/files/ffmpeg.patch (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Hi This and 120298 pr already commited. Can please anybody close it? -- Adios
State Changed From-To: feedback->closed Submitter notes that this has been committed.